Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make TwitchPubSubClient.DisconnectedAfter1s test less flaky #5461

Conversation

pajlada
Copy link
Member

@pajlada pajlada commented Jun 16, 2024

we were testing a bit too much here, and with a bit too little leeway. this should make tests easier to pass (while the logic we're testing is still being tested)

@pajlada
Copy link
Member Author

pajlada commented Jun 16, 2024

image

@pajlada pajlada enabled auto-merge (squash) June 16, 2024 12:01
@pajlada pajlada merged commit d053a68 into master Jun 16, 2024
17 checks passed
@pajlada pajlada deleted the fix/make-twitchpubsubclient-disconnected-after-1s-test-less-flaky branch June 16, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant