feat: add /warn command
#5474
Merged
feat: add /warn command
#5474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nerixyz
reviewed
Jun 20, 2024
pajlada
approved these changes
Jun 22, 2024
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| // /warn | ||
| // The extra parenthesis around the failure callback is because its type | ||
| // contains a comma | ||
| MOCK_METHOD( |
There was a problem hiding this comment.
warning: invalid case style for function 'MOCK_METHOD' [readability-identifier-naming]
Suggested change
| MOCK_METHOD( | |
| mockMethod( |
| @@ -621,6 +621,18 @@ enum class HelixBanUserError { // /timeout, /ban | |||
| Forwarded, | |||
| }; // /timeout, /ban | |||
|
|
|||
| enum class HelixWarnUserError { // /warn | |||
There was a problem hiding this comment.
warning: enum 'HelixWarnUserError' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size]
enum class HelixWarnUserError { // /warn
^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5439