Fixed splits staying paused after unfocusing Chatterino in certain configurations #5504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mm2PL
force-pushed
the
fix/unpause-visible-splits-on-window-onfocus
branch
from
0ed5755
to
65dda47
Compare
Mm2PL
changed the title
pajlada
approved these changes
Jul 13, 2024
Nerixyz
reviewed
Jul 13, 2024
| @@ -77,6 +77,9 @@ class Split : public BaseWidget | |||
|
|
|||
| void setInputReply(const MessagePtr &reply); | |||
|
|
|||
| // This is called on window focus lost | |||
There was a problem hiding this comment.
Documentation should say what an entity does, not where it's used. It could say where it's supposed to be used.
|
@Mm2PL Thank you for fixing this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5502.