fix: make borders on windows 11 thinner #5836
Conversation
|
Just tested. Works as it should. 👍🏻 |
|
Maybe unrelated to the PR (not sure since it claims to fix #5645), but the chat box border still looks bad compared to the 2.5.1 release. Resizing the window just causes it to shift around. 🤔 |
I think that's a separate issue. This PR only fixes the border of the application window. For the split input, I don't know what the best solution is. Yes, I can remove the margins, but then multiple horizontal splits will look bad next to each other (notice: the margin is inside the split, not inside the window). The question is basically: How should this look?
And... I don't know.
Is that a separate bug with this PR? Resizing the window works as expected for me. |
Sorry for not replying to you quicker. To answer your question, nope, it's not a bug with this PR. I just thought I should bring it up since it's been bothering me. I guess creating a new PR for this issue (if it can even be fixed) would be better. 👍🏻 recording.mp4 |
Yea, it's better to do this separately. This looks like a Qt bug (some float → int conversion maybe?). Or it's some scaling "bug". |
It seems like Windows 11 automatically adds a border for us. If we manually add one, we make it thicker, which doesn't look nice (notice the thick border on the left).
Now, the border doesn't change its color when selected/unselected, but that seems to be the common way on Windows 11 (I tested Firefox).
✨ Comparison ✨
(I hope this fixes) #5645.