Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor updates for 2.5.1 #385

Merged
merged 6 commits into from
May 25, 2024

Conversation

Felanbird
Copy link
Collaborator

No description provided.

Copy link

netlify bot commented May 21, 2024

Deploy Preview for chatterino-wiki-dev ready!

Name Link
🔨 Latest commit 5080ee0
🔍 Latest deploy log https://app.netlify.com/sites/chatterino-wiki-dev/deploys/664cf02c55d6ab0008eb2d7c
😎 Deploy Preview https://deploy-preview-385--chatterino-wiki-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Mm2PL
Copy link
Contributor

Mm2PL commented May 21, 2024

I don't think we should remove version numbers on features. Replacing nightly notices with release version numbers is good though.

@Felanbird
Copy link
Collaborator Author

It just feels unnecessary to prefix features with a version after x amount of time (a bit over a year for all of these), in this case especially since if you're on a version older than this you basically already don't have a correctly functioning client.

I've done this a few times previously and if we didn't it would just be so much irrelevant version info on features.

Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that these changes should be done. If we hadn't removed the previous annotations then the wiki would be full of (added in X) that provide less and less value for each day that passes.

I think it's good to wait, like you've done now, a few weeks or so after release to allow people time to update

@pajlada pajlada merged commit d713307 into Chatterino:master May 25, 2024
6 checks passed
@Felanbird Felanbird deleted the 2.5.1-stuff-i-didnt-do-yet branch May 25, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants