This repository was archived by the owner on Jul 7, 2025. It is now read-only.
fix: do not leak username to untrusted modules #736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We must not leak the filesystem structure when the code is running inside a sandboxed environment. Only path relative to the project root should be available to the module. Signed-off-by: Miroslav Bajtoš <[email protected]>
Signed-off-by: Miroslav Bajtoš <[email protected]>
Signed-off-by: Miroslav Bajtoš <[email protected]>
Signed-off-by: Miroslav Bajtoš <[email protected]>
Signed-off-by: Miroslav Bajtoš <[email protected]>
bajtos
changed the title
Member
juliangruber
left a comment
juliangruber
left a comment
There was a problem hiding this comment.
Idea sounds great to me, I'll step back in favor of Nikolas' review here
NikolasHaimerl
approved these changes
Apr 22, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We must not leak the filesystem structure when the code is running inside a sandboxed environment. The Checker App files are usually in the user's home directory. The full path includes the username, which is sensitive information we should not leak to untrusted modules. The modules should have access only to the path relative to the project (module) root.
Before:
After:
I discovered this issue while working on #735
Parent issue: