fix(gemini): honor x-gemini.description override in command TOML#464
Merged
Conversation
commandTOML read only the top-level description and excluded it from the x-gemini pass-through keys, so an x-gemini.description override was silently dropped and the Claude-side description emitted instead. Resolve through emit.ResolveMeta first, matching codex skillMarkdown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
commandTOMLread only the top-leveldescriptionand excluded it from thex-geminipass-through keys, so anx-gemini.descriptionoverride was silently dropped and the Claude-side description emitted instead.emit.ResolveMeta(e.Meta, target)first, mirroringcodexskillMarkdown(the emit: codex skill ignores x-codex.description override #312 pattern). Affects Gemini agents, commands, and skills (all render viacommandTOML).Found via the emit-layer bug-hunt.
Test plan