Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHIA-2222 Annotate analyze-chain.py #19143

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AmineKhaldi
Copy link
Contributor

Purpose:

This allows the file (and its users) to benefit from type checking.

Current Behavior:

This file is excluded from mypy type checking.

New Behavior:

This file is now type annotated and included in mypy type checking.

@AmineKhaldi AmineKhaldi added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup labels Jan 14, 2025
@AmineKhaldi AmineKhaldi self-assigned this Jan 14, 2025
@AmineKhaldi AmineKhaldi force-pushed the annotate_analyze_chain branch from 803dfc5 to 99f307c Compare January 15, 2025 15:36
@AmineKhaldi AmineKhaldi force-pushed the annotate_analyze_chain branch from 99f307c to ba54ebc Compare January 22, 2025 10:33
Copy link

Pull Request Test Coverage Report for Build 12906321974

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 19 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.02%) to 91.531%

Files with Coverage Reduction New Missed Lines %
chia/plotters/plotters.py 1 90.94%
chia/wallet/wallet_node.py 1 88.25%
chia/timelord/timelord_launcher.py 2 89.29%
chia/server/node_discovery.py 3 81.32%
chia/plotters/madmax.py 6 44.58%
chia/full_node/full_node.py 6 86.31%
Totals Coverage Status
Change from base Build 12894248841: 0.02%
Covered Lines: 105339
Relevant Lines: 114908

💛 - Coveralls

@AmineKhaldi AmineKhaldi marked this pull request as ready for review January 22, 2025 13:27
@AmineKhaldi AmineKhaldi requested a review from a team as a code owner January 22, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants