-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend the BLSCache to add in a rust Pybinding for validate_clvm_and_signature for use in the mempool #637
Open
matt-o-how
wants to merge
25
commits into
main
Choose a base branch
from
validate_clvm_and_sigs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+809
−46
Open
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
fcb3288
use uncached tree_hash()
matt-o-how 0a986d0
fmt
matt-o-how 279f60e
add test for get_conditions_from_spendbundle()
matt-o-how 81a3ca6
make get_conditions_from_spendbundle() return a non-owned SpendBundle…
arvidn a8638bb
intitial commit
matt-o-how 4e1cd22
cargo fmt
matt-o-how 696da41
add a pairinginfo type to make clippy happy
matt-o-how da62f2a
fmt
matt-o-how 1efd030
black tests
matt-o-how 75f7d96
use pairinginfo type in pybinding
matt-o-how 575ff63
pybindings clippy changes
matt-o-how e0ae829
clippy cache improvements
matt-o-how 9904e06
fmt again
matt-o-how 8a3c9d5
blscache.items() returns bytes, blscache.update() takes bytes
matt-o-how ed15954
fix pystubs
matt-o-how b7220d7
rename comment in api
matt-o-how 327df7c
undo unjustified changes
matt-o-how 363f506
move PyBackedBytes import
matt-o-how b2aa033
fix rebase detritus
matt-o-how e85505e
fmt
matt-o-how 79f73d7
convert newly returned SBC to OSBC
matt-o-how 1fdc4d1
change u64_to_bytes to pub(crate)
matt-o-how ffb68ce
rebase cleanup
matt-o-how 88e4af3
fmt again
matt-o-how faa0f58
remove parent, puzzle, and msg as defined cases in aggsig test
matt-o-how File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
cargo fmt
commit 4e1cd225278eaa0a6cebf692591400db9211b0bd
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -279,4 +279,4 @@ pub mod tests { | |
|
||
assert!(bls_cache.aggregate_verify(pks_msgs, &Signature::default())); | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you should pass in the cache here