Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix __repr__ for ConsensusConstants to use upper case names #904

Merged
merged 1 commit into from
Jan 28, 2025
Merged

fix __repr__ for ConsensusConstants to use upper case names #904

merged 1 commit into from
Jan 28, 2025

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Jan 24, 2025 •
edited
Loading

when using the py_uppercase parameter to the chia_py_streamable macro, the __repr__ still print the members as lower case.

@arvidn arvidn force-pushed the constants-upper-case branch from 22f99be to 46b8f32 Compare January 24, 2025 21:33
@arvidn arvidn marked this pull request as ready for review January 24, 2025 21:50
@arvidn arvidn requested a review from Rigidity January 24, 2025 21:50
@coveralls-official Coveralls Official
Copy link

Pull Request Test Coverage Report for Build 12958002706

Details

  • 29 of 29 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 84.454%
Totals Coverage Status
Change from base Build 12957422465: 0.02%
Covered Lines: 13554
Relevant Lines: 16049
💛 - Coveralls

@arvidn arvidn merged commit 1a62fe7 into main Jan 28, 2025
52 checks passed
@arvidn arvidn deleted the constants-upper-case branch January 28, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rigidity Rigidity Rigidity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arvidn @Rigidity