[Fusion] Add tests for various error cases #7006
Open
+13,512
−1,564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
michaelstaib
force-pushed
the
main
branch
2 times, most recently
from
8a97a79
to
e2d2300
Compare
tobias-tengler
force-pushed
the
fusion-error-handling
branch
3 times, most recently
from
69328d3
to
af35a84
Compare
tobias-tengler
force-pushed
the
fusion-error-handling
branch
8 times, most recently
from
2598fef
to
84859e8
Compare
tobias-tengler
changed the title
tobias-tengler
force-pushed
the
fusion-error-handling
branch
from
84859e8
to
3e81e5a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7006 +/- ##
==========================================
+ Coverage 75.88% 75.96% +0.07%
==========================================
Files 2376 2679 +303
Lines 116553 132758 +16205
==========================================
+ Hits 88451 100853 +12402
- Misses 28102 31905 +3803
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@tobias-tengler have marked the once that are tests that are not ok so we know what to fix? |
|
It's all but one test that isn't currently failing, mostly because of the errors. I've skipped them all for now though and made the previous |
|
Awesome ... I will have a look at it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a number of tests for both the handling of transport and individual subgraph errors. The
dataportion of the response is as expected in most cases, but errors and especially their paths are incorrect most of the time. This is problematic for error handling clients such as Relay which will expect error paths to the leaf field that has been nulled by the error.I've also added a new
TestSubgraphandTestSubgraphCollectionto simplify simulating Fusion composition and execution in the scope of a single test without having to update the Demo Subgraphs used for other integration tests.This PR doesn't change any functionality, it just adds tests and the expected + current snapshot versions. I plan to use this as a foundation on which to submit subsequent PRs to (hopefully) address all of the issues surfaced by these tests.
I'm sorry for the large diff, but I wanted to have all error cases I could think of covered by tests before modifying the behavior and accidentally changing correct behavior.
3e81e5a: This commit shows what is currently produced, compared to the expected response.