docs: add docker installation instructions #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangszwei
commented
Jan 10, 2024
yangszwei
commented
- Add Docker installation instructions in zh-TW.
Chinlinlee
reviewed
Jan 13, 2024
There was a problem hiding this comment.
@yangszwei 非常感謝你所提出的 Docker 安裝教學，我留下了幾個問題，不過最重要的是，這樣的文件，我覺得需要移動到 Discussions 內。另外， DEV Branch 的 Dockerfile 已經更新，所以安裝教學還需要更新
| 1. 從 [GitHub](https://github.com/Chinlinlee/Burni) 下載專案。 | ||
|
|
||
| ```bash | ||
| gh repo clone Chinlinlee/Burni |
There was a problem hiding this comment.
請問這是否要提醒使用者必須安裝 Github CLI ??
| cp plugins/config.template.js plugins/config.js | ||
| ``` | ||
|
|
||
| 6. 建立 `Dockerfile`。 |
There was a problem hiding this comment.
目前 DEV 中的 Dockerfile 已經改由 Java JDK 為底(因為 validator)的 Image，所以這個 Dockerfile，算是有點過期了
| ``` | ||
|
|
||
|
|
||
| 8. 啟動 Docker Compose 專案。 |
There was a problem hiding this comment.
以下章節有點像是額外內容，我們是否應該把這份 docker installation 的手冊移至 Disccusion 會比較合適?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.