Skip to content

Commit

Permalink
fix: incorrect frame when retrieve multiple frames
Browse files Browse the repository at this point in the history
# Problems
- Related: 3d7db77
- we should use number in array, not length (i)
- array should be 1 to n, not 0 to n
  • Loading branch information
Chinlinlee committed Oct 29, 2023
1 parent 5f1be7d commit e870cb1
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions api/dicom-web/controller/WADO-RS/service/rendered.service.js
Original file line number Diff line number Diff line change
Expand Up @@ -388,12 +388,13 @@ async function postProcessFrameImage(req, frameNumber, instanceFramesObj) {
*/
async function writeRenderedImages(req, dicomNumberOfFrames, instanceFramesObj, multipartWriter) {
try {
// Check if dicomNumberOfFrames is an Array, if it is not an Array then convert it to a 0 to N number Array.
// Check if dicomNumberOfFrames is an Array, if it is not an Array then convert it to a 1 to N number Array.
let frames = dicomNumberOfFrames;
if (!Array.isArray(frames)) frames = [...Array(frames).keys()];
if (!Array.isArray(frames)) frames = [...Array(frames).keys()].map(i => i + 1);

for (let i = 0 ; i < frames.length; i++) {
let postProcessResult = await postProcessFrameImage(req, i+1, instanceFramesObj);
let frameNumber = frames[i];
let postProcessResult = await postProcessFrameImage(req, frameNumber, instanceFramesObj);
let buffer = postProcessResult.magick.toBuffer();
multipartWriter.writeBuffer(buffer, {
"Content-Type": "image/jpeg",
Expand Down

0 comments on commit e870cb1

Please sign in to comment.