Video Premiere UI for Scheduled Videos

[KozielGPC]

Description

This PR adds the Video Premiere UI for Scheduled Videos

Related issues

• Video Premiere UI for Scheduled Videos - Set Reminder #6705

Has this been tested?

• 👍 yes, I added tests to the test suite
• 💭 no, because this PR is a draft and still needs work
• 🙅 no, because this PR does not update server code
• 🙋 no, because I need help

Screenshots

Added Scheduled privacy type when posting a video

When user is not subscribed to the channel

When user is subscribed to the channel

[Chocobozzz]

Hi and thanks for the PR! Can you revert formatting changes and respect our Eslint convention? (no ; for example). Because the PR in its current state is difficult to review :)

[KozielGPC]

@Chocobozzz sure! I updated the code pulling updates from your repo to avoid conflicts, but I'm kinda having some difficulties setting up Eslint in my project. I don't know if there is some problem with gitpod codespace or what am I missing, but it is not applying your eslint rules. I'll try to fix it ASAP and set open for review again

[candidexmedia]

Hello, any updates on this? 😊

[Leatherface75]

Ping @KozielGPC

[KozielGPC]

Hey @Leatherface75 @candidexmedia , I'm so sorry about the late response. I was in some busy days finishing my graduation and adjusting some things to move to another country. I'll take a look on it this weekend and hopefully it can be ready to merge!

[candidexmedia]

Congrats on graduating and on your big move! Looking forward to seeing this PR come to life ✨🙂

[KozielGPC]

Hey everyone, good news! It's ready for review now!

@Chocobozzz @candidexmedia @Leatherface75 @stevespaw

[Chocobozzz]

Can you explain why you need another video privacy? Why don't you just use the scheduledUpdate attribute to know if the video has a countdown?

[KozielGPC]

For me it made more sense to have a different privacy type instead of moving a video from PRIVATE to the SPECIAL_SCHEDULED_PRIVACY = -1. In that way we have a better separation of responsibilities, in case we need to use scheduledUpdate for a different thing other than a video premiere

[Chocobozzz]

Thank you for the explanation. I think we should keep PRIVATE to not have to handle another video privacy that has the same behaviour as PRIVATE. Instead, I suggest inferring video premiere UI based on the scheduleUpdate value (if current privacy is PRIVATE and scheduled privacy is PUBLIC). We may also add a checkbox in video edit form so video makers choose if they want to display that information or not.