API-access for external auth plugins #7182
Draft
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows auth plugins to return the bypass token as a JSON response, rather than in a redirection. Using a redirect and putting the bypass token in the query parameter works when the browser goes through the login flow using the PeerTube frontend and redirect back to an external frontend afterwards. But for a purely API based access from an external frontend, the redirect does not work. See https://framagit.org/framasoft/peertube/official-plugins/-/merge_requests/33 for more details on why it does not work and how the proposed change can be used in a plugin.
jakmeier
force-pushed
the
external-auth-api
branch
from
4b4b1cd to
8d204b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows auth plugins to return the bypass token as a JSON response, rather than in a redirection.
Using a redirect and putting the bypass token in the query parameter works when the browser goes through the login flow using the PeerTube frontend and redirect back to an external frontend afterwards. But for a purely API based access from an external frontend, the redirect does not work.
See https://framagit.org/framasoft/peertube/official-plugins/-/merge_requests/33 for more details on why it does not work and how the proposed change can be used in a plugin.
Description
Related issues
#7181
Has this been tested?