Fix client overrides not overriding logo.svg #7374
Open
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If users wish to change PeerTube's logo to their own SVG logo, they only have one option: client overrides. This is because the
.svgfile extension is not supported by the custom logo configuration in the UI. This is problematic if users want their custom logo to appear clearly, without blurriness such as the result of uploading a.pngfile. I have first-hand experience with this frustration.The
logo.svgfile wasn't whitelisted in the NGINX configuration to be overridden by the client-overrides feature, therefore even if users placed thelogo.svgfile in the correct directory/assets/imagesthe logo would not be overridden. This PR fixes this issue by simply whitelisting thelogo.svgfilename.Related issues
https://framacolibri.org/t/override-logo-and-icon-with-client-overrides/9634
#3292 (this PR re-fixes overriding logo.svg)
#2897 (comment)
Has this been tested?
Yes, I have manually edited the NGINX configuration on my live production instance at https://peertube.tech. You can see the logo.svg file being replaced at: https://peertube.tech/client/assets/images/logo.svg
This option also applies, but I have tested it on my instance.
🙅 no, because this PR does not update server code
🙋 no, because I need help
Screenshots
The custom logo not becoming blurry when scaled 500% in the browser.
When uploading a custom logo through the UI, it looks unclear and blurry at the same 500% scale like the previous screenshot.
