Lpd 29195 continuation 7 #328
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al, and relocating logic to the correct page
…d SP connections to be removed first if they already exist. This prevents unique ID errors from occurring, and allows the test to continue as usual.
…s logic would attempt to create a certificate afterwards, which would cause problems. Now, we only create/replace a cert if needed, and we prevent a repetitive save action.
…l, which doesn't have the same mail and web domain names.
…MLWithMultipleIdPs / LPD-24989. Remove existing flaky poshi test as well.
…on't have to re-navigate to the same page to perform another action.
beforeAll method, which will setup the saml keystore manager target and create the able and baker instances. afterAll method, which will reset the keystore manager target, delete the virtual instances, and delete user and custom field test data from localhost. afterEach method, which will clear all provider connections and disable SAML for each configured instance. With this, it is now expected from each test to configure virtual instances for SAML as needed. This is so we have more control over what and how we test, as well as prevent any left-over test data from bleeding into subsequent tests.
…cases where we expect a failure message
…ing it's possible to send a null value. Add an undefined check to prevent NPE-like problems.
…nnotBeSavedInSAML, so we can remove it now. See LPD-24991
…e the method name to reflect this.
… Rename so it's not confusing if we use it for SP user creation.
…e IdP and redirect to the SP
…nd the entire SAML System Settings to be reset
1) allow goTo methods to not force reload, so we don't need to re-navigate to the given page 2) Have util methods expect authenticated admin page of the given instance, rather than recreating it each time. 3) Have virtual instance creation and SAML configuration type methods return an authenticated admin page.
…Requests requirements. See LPS-128578.
…nfigurations. If a given configuration value is null, assume we want to reset it to the default value.
…SSOWithSignAuthnRequests
…uccess massage on the page, which causes playwright errors. Close them after we've verified them.
…ess user error while creating tests.
…can accumulate 20+ pages before it even runs.
…L Admin page, there is a race condition between reloading the page and clicking on the Identity or Service Provider Connections tab. This results in the addXProviderConnection method to not detect the existing connection, so it tries to re-add it, causing name conflicts or connections from previous tests to be used.
…ll method will be invoked before attempting to run the next test. In these cases, there is a chance the test will already begin on the beforeAll method before the virtual instances can be completely removed. This causes problems because the portal already believes the virtual instance is created, even though it is in the process of being deleted.
…connections. Note, attribute mapping creation is now moved below user resolution selection, otherwise the matching toggle for a given attribute may not work if the previous user resolution type wasn't 'attribute'.
… a successful SSO.
…BeUsedForUserMatchingInSAML. Remove poshi test as well.
…usted if a new field is added or removed. This was discovered after the test in LPD-30074 was created, so it will not pass unless this fix is present.
…s enabled, we already click the reset button.
…en the SP isn't authenticated, but the IdP already is
…LogoutWorkSameWhenSitesConfiguredAsSP
…lyToSitesAfterACSDisabled
|
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
|
ci:test:sf |
|
ci:test:playwright |
✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPD-29195-continuation-7 1 Successful Jobs:For more details click here. |
liferay-continuous-integration
added
ci:test:playwright - failure
and removed
ci:test:playwright - pending
labels
Target exception: java.lang.RuntimeException: java.io.IOException: Server returned HTTP response code: 400 for URL: https://testray.liferay.com/o/oauth2/token Base Branch:Branch Name: master Branch GIT ID: a0e0a171fb12927582c213503d786ea1c82e1e2a Job Summary:Job Link: test-portal-acceptance-pullrequest(master) For more details click here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.