Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add colors to d2r-loot-filters #591

Merged
merged 3 commits into from
Sep 22, 2024

Conversation

nnyyxxxx
Copy link
Contributor

Type of Change

  • Refactoring

Description

quotes vars to prevent globbing, adds colors, uses command_exists function defined in common-script

Testing

needs testing, though it should work fine. can't test because i don't own the game, but the first 18 lines work:

image

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • My changes generate no errors/warnings/merge conflicts.

Co-authored-by: Liam <[email protected]>
@nnyyxxxx nnyyxxxx mentioned this pull request Sep 22, 2024
4 tasks
@nnyyxxxx nnyyxxxx changed the title Add colors to d2r-loot-filters & use command_exists instead of command -v Add colors to d2r-loot-filters Sep 22, 2024
@ChrisTitusTech ChrisTitusTech merged commit 72eb865 into ChrisTitusTech:main Sep 22, 2024
2 checks passed
@nnyyxxxx nnyyxxxx deleted the addcolorstod2rlf branch September 22, 2024 16:11
@ChrisTitusTech ChrisTitusTech added the enhancement New feature or request label Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants