Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont allow scrolling when last line is visible #729

Conversation

nnyyxxxx
Copy link
Contributor

@nnyyxxxx nnyyxxxx commented Oct 2, 2024

watch the video

Type of Change

  • New feature
  • Refactoring

for the color bleeding u see in the video and image its solved with this PR #723

Description

before:
image

after:

2024-10-02-03-54-05.mp4

Copy link
Collaborator

@adamperkowski adamperkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended. No bugs when resizing the window while in preview.

tui/src/floating_text.rs Outdated Show resolved Hide resolved
tui/src/floating_text.rs Outdated Show resolved Hide resolved
Co-authored-by: Adam Perkowski <[email protected]>
@shauryaaa99
Copy link

needed one

@ChrisTitusTech ChrisTitusTech merged commit 3813833 into ChrisTitusTech:main Oct 31, 2024
2 checks passed
@nnyyxxxx nnyyxxxx deleted the dont-allow-scrolling-past-last-line branch November 1, 2024 21:04
@nnyyxxxx nnyyxxxx mentioned this pull request Nov 6, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants