-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement word wrapping functionality #755
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK from a first glance.
I removed the FloatingTextMode a few days ago, so we can use any title we want. |
that's already implemented via enum rather than boolean |
Yes, I know, that enum existed a few days ago, and it was removed to make the float more generic, so that the title can be anything instead of just those 3 enum types. That's why I was saying that a boolean is better. Check the current implementation and you will understand. Why should we restrict the float to just those 3 types when all we need is to either wrap or not? |
oh i didnt notice |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@ChrisTitusTech this pr adds word wrapping to descriptions and the important actions guide, it can be enabled for previews as well if you want.
Type of Change
Description
adds dynamic / auto updating word wrapping to the descriptions