Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact(ci): bashisms.yml #793

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

jeevithakannan2
Copy link
Contributor

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactoring
  • Hotfix
  • Security patch
  • UI/UX improvement

Description

  • Fixed bashisms not working when manually ran.
  • Trigger bashisms workflow only when sh files are changed in PRs ( Previously changes to any file inside tabs dir triggered the workflow ).
  • Use tj-actions/changed-files action to get the changed files in PRs.

Testing

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

@adamperkowski adamperkowski added the github_actions Pull requests that update GitHub Actions code label Oct 25, 2024
@adamperkowski adamperkowski changed the title ci: Rework bashisms.yml refact(ci): bashisms.yml Oct 30, 2024
@ChrisTitusTech ChrisTitusTech merged commit 5987d0d into ChrisTitusTech:main Nov 1, 2024
1 check passed
@jeevithakannan2 jeevithakannan2 deleted the bashisms.yml branch November 1, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants