Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Command execution log #898

Merged
merged 9 commits into from
Nov 8, 2024

Conversation

jeevithakannan2
Copy link
Contributor

@jeevithakannan2 jeevithakannan2 commented Nov 1, 2024

Type of Change

  • New feature

Description

  • Add feature to save the command execution log by pressing l after the command execution.
  • Writes the buffer to a temp file.
  • The log is saved in /tmp/linutil_log_YYYY-MM-DD-HH-MM-SS.log

Testing

2024-11-01.18-11-31.mp4

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no errors/warnings/merge conflicts.

@adamperkowski adamperkowski added enhancement New feature or request rust Pull requests that update Rust code labels Nov 1, 2024
@adamperkowski
Copy link
Collaborator

I think using the UNIX timestamp instead of YYYY-MM-DD-HH-MM-SS is a much better idea.

@jeevithakannan2
Copy link
Contributor Author

Human Readable form YYYY-MM-DD-HH-MM-SS is used for logs rather than a unix time stamp because it is more convenient for the user.

@adamperkowski
Copy link
Collaborator

Well, ok. How much bigger is the binary with time?

@jeevithakannan2
Copy link
Contributor Author

jeevithakannan2 commented Nov 1, 2024

No crates with unix time stamp -> 4283240
crate time with human readable -> 4295528
create chrono with human readable -> 4336488

@nnyyxxxx
Copy link
Contributor

nnyyxxxx commented Nov 1, 2024

why is this a necessary feature? i see no use in this at all

@jeevithakannan2
Copy link
Contributor Author

Will be easier to debug script errors compared to a screen shot. Also its in the roadmap

Copy link
Contributor

@nnyyxxxx nnyyxxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

roadmap needs editing as well

@nnyyxxxx
Copy link
Contributor

nnyyxxxx commented Nov 1, 2024

image
box needs checked

Copy link
Collaborator

@adamperkowski adamperkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nnyyxxxx i do see how one would use this but i still think epoch would be a better idea

@ChrisTitusTech ChrisTitusTech merged commit 8639da3 into ChrisTitusTech:main Nov 8, 2024
2 of 3 checks passed
@jeevithakannan2 jeevithakannan2 deleted the logs branch November 8, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants