-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(fedora): Recent syntax changes with DNF5 #907
Conversation
I think adding a version check is more robust way |
Do we really need to do that, most fedora downstream will switch to dnf5 if they haven't already done it. |
Are they switching to dnf5 in fedora 39 and 40 also? |
No idea. @Angxddeep please research this, add a version check (if applicable) and then mark this PR as ready for review. Thanks. |
No. This PR absolutely cannot be merged as is. |
I am a bit busy with life for a week. Ill will try to do it after that |
fedora 39, 40 have |
They only have dnf5 as experimental in the repos, it's not installed by default |
Yes, but it still could be installed; the dnf symlink will continue to point to dnf4 in that case. You would need to explicitly call dnf5 to ensure the correct program is used. |
What if the user symlinked the dnf to dnf5? dnf --version and some cuts this reduces complexity |
I am going to be honest, fedora 39 will be EOL in a month and linutil isn't popular enough and most people will upgrade to 41 in no time. As is said I am a bit busy I think we should merge this so at least it works for people who have upgraded to F41. If you guys can submit changes that will be good too |
Co-authored-by: Jeevitha Kannan K S <[email protected]>
Co-authored-by: Jeevitha Kannan K S <[email protected]>
* Dnf5 fixes * again fix :) * final fix * added version check * Apply suggestions from code review Co-authored-by: Jeevitha Kannan K S <[email protected]> * Update core/tabs/applications-setup/Developer-tools/sublime-setup.sh Co-authored-by: Jeevitha Kannan K S <[email protected]> --------- Co-authored-by: Jeevitha Kannan K S <[email protected]>
Type of Change
Description
There have been a recent syntax change in dnf5 which comes preinstalled with every distro based on fedora 41 or later, therefore I have updated all the setup scripts which requires --add-repo and replaced it with addrepo --from-repofile="https://...". Also @jeevithakannan2 has added a version check so it doesn't conflict with systems that are not on dnf5.
Testing
Works. Although there is an issue with upstream braves repo file, I have created an issue on their GitHub page. It will start working again once they update the upstream repo file. I think this should be merged regardless as currently no script is working with dnf5 after this 3 out of 4 will start working and after brave fixes the issue all 4 will work.
Checklist