Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Mouse scroll #913

Merged
merged 8 commits into from
Nov 11, 2024
Merged

feat: Mouse scroll #913

merged 8 commits into from
Nov 11, 2024

Conversation

jeevithakannan2
Copy link
Contributor

@jeevithakannan2 jeevithakannan2 commented Nov 4, 2024 •
edited
Loading

Type of Change

  • New feature
  • UI/UX improvement

Description

  • Add mouse scroll in all directions.
output.mp4

Testing

  • Tested on arch linux with no issues.

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no errors/warnings/merge conflicts.

@adamperkowski adamperkowski added enhancement New feature or request UI/UX labels Nov 4, 2024
lj3954
lj3954 suggested changes Nov 5, 2024
View reviewed changes
tui/src/main.rs Outdated Show resolved Hide resolved
tui/src/confirmation.rs Outdated Show resolved Hide resolved
tui/src/state.rs Outdated Show resolved Hide resolved
nnyyxxxx
nnyyxxxx suggested changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@nnyyxxxx nnyyxxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be togglable and off by default

@jeevithakannan2
Copy link
Contributor Author

this should be togglable and off by default

Why would someone want that?

@nnyyxxxx
Copy link
Contributor

nnyyxxxx commented Nov 5, 2024

this should be togglable and off by default

Why would someone want that?

this is a tui application ran in the terminal having mouse interaction without a toggle is poor ux by default

@ChrisTitusTech ChrisTitusTech merged commit 432d6b3 into ChrisTitusTech:main Nov 11, 2024
2 checks passed
jeevithakannan2 added a commit to jeevithakannan2/linutil that referenced this pull request Nov 11, 2024
@jeevithakannan2 @lj3954
feat: Mouse scroll (ChrisTitusTech#913)
70da944 
* feat: add mouse scrolling

* revert: bluetooth-manager.sh

* feat: mouse hori scrolls

* Update tui/src/main.rs

Co-authored-by: Liam <[email protected]>

* Update tui/src/confirmation.rs

Co-authored-by: Liam <[email protected]>

* feat: implemetation of mouse position

Suggested by Liam (<[email protected]>)

---------

Co-authored-by: Liam <[email protected]>
@nnyyxxxx nnyyxxxx mentioned this pull request Nov 12, 2024
Closed
@jeevithakannan2 jeevithakannan2 deleted the mouse-scroll branch November 16, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nnyyxxxx nnyyxxxx nnyyxxxx requested changes

@lj3954 lj3954 lj3954 requested changes

@ChrisTitusTech ChrisTitusTech ChrisTitusTech approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jeevithakannan2 @nnyyxxxx @ChrisTitusTech @lj3954 @adamperkowski