Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Rounded corners #918

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

nnyyxxxx
Copy link
Contributor

@nnyyxxxx nnyyxxxx commented Nov 6, 2024

Type of Change

  • New feature

Description

adds rounded corners to the tui boxes

Testing

image

@nnyyxxxx
Copy link
Contributor Author

nnyyxxxx commented Nov 6, 2024

applies to script previews, descriptions, etc. As well.

@afonsofrancof
Copy link
Collaborator

Can the rectangle highlighting the currently hovered item also have rounded corners?

@adamperkowski
Copy link
Collaborator

Can the rectangle highlighting the currently hovered item also have rounded corners?

I don't think it can. Even if it did, do we want it to?

@nnyyxxxx
Copy link
Contributor Author

nnyyxxxx commented Nov 6, 2024

Can the rectangle highlighting the currently hovered item also have rounded corners?

i think it would look ugly

@nnyyxxxx nnyyxxxx marked this pull request as draft November 6, 2024 19:23
@nnyyxxxx nnyyxxxx marked this pull request as ready for review November 6, 2024 19:27
@ChrisTitusTech ChrisTitusTech merged commit c36879e into ChrisTitusTech:main Nov 6, 2024
2 checks passed
@nnyyxxxx nnyyxxxx deleted the rounded_corners branch November 6, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants