make mouse interaction wrap back #938
Conversation
|
Scrolling with mouse is sensitive that's why it was not implemented ( Also why are you adding unnecessary code if you can just call the scroll_up and scroll_down functions ) . This makes the UX experience worse. Don't want the user to go bazooka if he just wants to select the last command. 2024-11-12.18-32-20.mp4 |
|
it's not sensitive for me |
It's generally not implemented anywhere you can take your browser or htop or btop for example |
|
it's a good QOL feature, i think everyone can agree with me on that + we should keep the synergy with keyboard movement, the user should expect a seamless transition between the two. |
|
anyways in the video your scroll wheel is clearly unlocked.. in the video i provided this is clearly not the case for me as i have a regular scroll wheel and i clearly didn't over exaggerate the movement in the video |
|
@ChrisTitusTech I am against this PR read through the comments before merging. |
|
Most people don't expect mouse scrolling to wrap around. I oppose this change. Mouse and keyboard input aren't supposed to function identically, they're very different tools. |
|
i agree with Liam on this one. to be honest, i'm against mouse functionality in linutil at all. sorry i'm not really active recently, will be back probably around next week. |
i agree, lets hope #942 gets merged since Chris also agree'd on discord as well |
|
i agree with the rest here, i'm going to close this as it will not be compatible with #946 |
Type of Change
Description
makes mouse interaction wrap back on last / first entry when scroll is attempted again in that direction, see video for a better explanation
we have this same feature for regular keyboard movement, btw
resolves #939
Testing
video is pretty laggy, you are warned !!
2024-11-12.05-56-35.mp4