Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use vt100-ctt instead of patching the dep #952

Merged
merged 1 commit into from
Nov 16, 2024
Merged

Use vt100-ctt instead of patching the dep #952

merged 1 commit into from
Nov 16, 2024

Conversation

jeevithakannan2
Copy link
Contributor

Merge ChrisTitusTech/vt100-rust#3 first

Type of Change

  • Bug fix

Description

Thanks @a-kenji
Use vt100-ctt instead of patching the dep.

Testing

  • Works without issues.

Issues / other PRs related

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no errors/warnings/merge conflicts.

@jeevithakannan2
Copy link
Contributor Author

jeevithakannan2 commented Nov 16, 2024 •
edited
Loading

The rust checks won't pass until ChrisTitusTech/vt100-rust#3 is merged. Tested with my github branch of vt100-ctt works without any issues.

@jeevithakannan2 jeevithakannan2 marked this pull request as ready for review November 16, 2024 20:04
@ChrisTitusTech ChrisTitusTech merged commit fa69885 into ChrisTitusTech:main Nov 16, 2024
1 of 2 checks passed
@adamperkowski adamperkowski added bug Something isn't working rust Pull requests that update Rust code labels Nov 17, 2024
@nnyyxxxx nnyyxxxx mentioned this pull request Nov 17, 2024
Closed
@jeevithakannan2 jeevithakannan2 deleted the tui_term branch November 17, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisTitusTech ChrisTitusTech ChrisTitusTech approved these changes

Assignees
No one assigned
Labels
bug Something isn't working rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

*IMPORTANT* packaged builds not working with patch.crates-io
3 participants
@jeevithakannan2 @ChrisTitusTech @adamperkowski