Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bluetooth manager #959

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix bluetooth manager #959

wants to merge 5 commits into from
+20 −27

Conversation

jeevithakannan2
Copy link
Contributor

Type of Change

  • Bug fix

Description

  • Added missing bluez package.
  • Removed unused variable action.
  • Fix usage of locally modified variable(i) value.
  • Strip of some unwanted comments
  • For some odd reason the read at the end of the loop is not working. So it was added to each if block.

Testing

  • Tested on arch linux without issues

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no errors/warnings/merge conflicts.

@jeevithakannan2
Fix bluetooth errors
1e1ea3c 
The i variable is edited locally as pipe is used. It results in error
when connecting to a device. The read -r at the last is not working for
some reason so added the read -r for each if case. Removed unused action
variable.
@jeevithakannan2
Add bluez package to arch linux
c73fd51
@jeevithakannan2
Remove unnecessary variable usage
b1b7ce0 
We don't need to use device_list variable while devices variable can be directly used
adamperkowski
adamperkowski approved these changes Nov 20, 2024
View reviewed changes
core/tabs/common-service-script.sh
checkInitManager 'systemctl rc-service'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you reset this file?

@adamperkowski adamperkowski added bug Something isn't working script Pull requests that update scripts labels Nov 20, 2024
AkkhilCodingHub
AkkhilCodingHub suggested changes Nov 30, 2024
View reviewed changes
Copy link

@AkkhilCodingHub AkkhilCodingHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to keep user input for going back to the main menue Or maybe implement to go to a specific section

@jeevithakannan2
Copy link
Contributor Author

We may want to keep user input for going back to the main menue Or maybe implement to go to a specific section

I think its already implemented right?

Entering 0 will take you to main menu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkkhilCodingHub AkkhilCodingHub AkkhilCodingHub requested changes

@adamperkowski adamperkowski adamperkowski approved these changes

Assignees
No one assigned
Labels
bug Something isn't working script Pull requests that update scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeevithakannan2 @adamperkowski @AkkhilCodingHub