Skip to content

feat(common-service): runit support#985

Merged
ChrisTitusTech merged 13 commits intoChrisTitusTech:mainfrom
Jaredy899:service-script
Jun 20, 2025
Merged

feat(common-service): runit support#985
ChrisTitusTech merged 13 commits intoChrisTitusTech:mainfrom
Jaredy899:service-script

Conversation

@Jaredy899
Copy link
Copy Markdown
Contributor

@Jaredy899 Jaredy899 commented Dec 24, 2024

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactoring
  • Hotfix
  • Security patch
  • UI/UX improvement

Description

I have updated the service script to address runit

Testing

Tested in Void Linux and Antix

Issues / other PRs related

Additional Information

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

@Jaredy899 Jaredy899 marked this pull request as ready for review December 24, 2024 12:55
@Jaredy899 Jaredy899 mentioned this pull request Dec 24, 2024
12 tasks
Comment thread core/tabs/common-service-script.sh Outdated
@koibtw koibtw changed the title Update common-service-script for runit feat(common-service): runit support Jan 2, 2025
Comment thread core/tabs/common-service-script.sh Outdated
@Jaredy899 Jaredy899 mentioned this pull request Jan 11, 2025
12 tasks
Comment thread core/tabs/common-service-script.sh Outdated
Cool with me. Thanks

Co-authored-by: Adam Perkowski <adas1per@protonmail.com>
Copy link
Copy Markdown
Collaborator

@koibtw koibtw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please take a look at this failing CI. It's complaining about formatting.

Comment thread core/tabs/common-service-script.sh Outdated
Jaredy899 and others added 3 commits January 11, 2025 09:25
Found it faster than me. Thanks

Co-authored-by: Adam Perkowski <adas1per@protonmail.com>
sv works with runit, and we don't need to sleep command.
@ChrisTitusTech ChrisTitusTech merged commit a9ab4d8 into ChrisTitusTech:main Jun 20, 2025
4 checks passed
@Jaredy899 Jaredy899 deleted the service-script branch June 20, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some Scripts Failing on non Systemd Debian Distributions

5 participants