Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Void linux support #994

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

Jaredy899
Copy link

@Jaredy899 Jaredy899 commented Jan 11, 2025

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactoring
  • Hotfix
  • Security patch
  • UI/UX improvement

Description

Add Void Linux support for many applications, also utilizing my previous common-service-script.

I messed up my previous PR while merging other things. This one is basically a redo.

Testing

Tested in Void Linux

Issues / other PRs related

Dependent on PR #985

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

@Jaredy899 Jaredy899 marked this pull request as ready for review January 11, 2025 13:31
Copy link
Collaborator

@adamperkowski adamperkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT although I'd love to have someone who's familiar with Void Linux to review those changes.
Also, @Jaredy899 take a look at failing CIs.

@adamperkowski adamperkowski added enhancement New feature or request script Pull requests that update scripts labels Jan 11, 2025
@adamperkowski
Copy link
Collaborator

#985 NEEDS TO BE MERGED FIRST

yes, this is necessary

Copy link
Collaborator

@adamperkowski adamperkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll open a PR to fix all shellcheck errors in the repo later

EDIT: #997

core/tabs/system-setup/compile-setup.sh Show resolved Hide resolved
Jaredy899 and others added 2 commits January 11, 2025 09:37
forgot to add xbps-install
Jaredy899 and others added 3 commits January 11, 2025 11:08
Awesome. Thanks for helping me learn all this stuff.

Co-authored-by: Adam Perkowski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request script Pull requests that update scripts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants