Modernize package #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ken-lauer
reviewed
Oct 18, 2024
.flake8
Outdated
There was a problem hiding this comment.
We aren't using flake8 really - ruff does all the linting and has its own settings in pyproject.toml - so I think this isn't necessary
|
|
||
| # Specify runner + deployment step | ||
| runs-on: ubuntu-latest | ||
| steps: |
There was a problem hiding this comment.
Be sure to update your GitHub pages settings (and remember the v* tag whitelist)
.pre-commit-config.yaml
Outdated
| exclude: "^(python/versioneer.py|python/src/_version.py)$" | ||
|
|
||
| - repo: https://github.com/astral-sh/ruff-pre-commit | ||
| rev: v0.6.2 |
There was a problem hiding this comment.
Run pre-commit autoupdate - these versions are behind
pmd_beamphysics/__init__.py
Outdated
There was a problem hiding this comment.
Since you're reformatting all of the code, you may as well sort imports now, too. That part isn't automatic in our configuration just yet.
ruff check --fix --extend-select=I pmd_beamphysics/
``
Co-authored-by: Ken Lauer <[email protected]>
…es/openPMD-beamphysics into modernize_package
ken-lauer
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modernizes the Python package infrastructure to the same level as LUME-Genesis:
pyproject.toml