Add convenience min, max properties to FieldMesh #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristopherMayes
changed the title
ken-lauer
reviewed
Oct 23, 2024
pmd_beamphysics/fields/fieldmesh.py
Outdated
| dtheta = _create_delta_property("theta") | ||
|
|
||
| # Maxs | ||
| def _create_max_property(name): |
There was a problem hiding this comment.
These property-creating helper functions don't have to live in the class body, just so you know
There was a problem hiding this comment.
thanks, changed.
| return property(getter, setter) | ||
|
|
||
| # Create max properties dynamically | ||
| xmax = _create_max_property("x") |
There was a problem hiding this comment.
While you're refactoring these, you might consider adding on a doc for each attribute. That could help with future documentation efforts.
https://docs.python.org/3/library/functions.html#property
property(..., doc="...")
ken-lauer
approved these changes
Oct 23, 2024
pmd_beamphysics/fields/fieldmesh.py
Outdated
| self.attrs["gridOriginOffset"] = tuple(mins) | ||
|
|
||
| return property( | ||
| getter, setter, doc=f"Mesh minimim in {name}. This can also be set." |
There was a problem hiding this comment.
Suggested change
| getter, setter, doc=f"Mesh minimim in {name}. This can also be set." | |
| getter, setter, doc=f"Mesh minimum in {name}. This can also be set." |
ChristopherMayes
deleted the
enable_impact_-emfield_cartesian_offsets_and_tilt
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It also refactors some of the convenience methods in
FieldMesh:FieldMesh.xmin,FieldMesh.ymin, etc.FieldMesh.xmax,FieldMesh.ymax, etc.