Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed social icons click while rotate animation #93

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

katareayush
Copy link
Contributor

@katareayush katareayush commented May 30, 2024

PR Description 📜

ISSUE NUMBER #114

Demo Video - Showing the working changes made in social Icon in footer
https://github.com/ChromeGaming/Squard-line/assets/144807559/7799ba7a-948d-400e-ac1c-d3a7c789b400

Please include summary related to the issue you have fixed and describe your PR in brief over here by specifying the issue number on which you were working below
Fixes # Bug Fixes.

Summary- While the background layer was getting rotated , the social icons were unresponsive and were not redirecting to the target , changed the code to optimize that bug.

No other components were disturbed in making this change.


Mark the task you have completed ✅

  • [x ] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • [x ] I have performed a self-review of my own code or work.
  • [x ] I have commented my code, particularly in hard-to-understand areas.
  • [x ] My changes generates no new warnings.
  • [x ] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for review.

## Add your screenshots(Optional) 📸

Thank you soo much for contributing to our repository 💗

Copy link
Member

@Durgesh4993 Durgesh4993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add issue number, demo video and don't forget resolve conflict file

@katareayush
Copy link
Contributor Author

Add issue number, demo video and don't forget resolve conflict file

Done all the necessary changes please have a look.

@katareayush katareayush requested a review from Durgesh4993 June 6, 2024 07:07
@Durgesh4993 Durgesh4993 added enhancement New feature or request level1 and removed Under Review labels Jun 7, 2024
@Durgesh4993 Durgesh4993 merged commit 389476e into ChromeGaming:main Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc level1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants