design: add supplier FAQ accordion with search - #504
Open
KingDavid9999 wants to merge 2 commits into
Open
Conversation
Add SupplierFaqAccordion to the supplier profile, implementing the WAI-ARIA disclosure pattern with searchable question/answer/category matching, matched-term highlighting, and deep-linking via URL hash (expand + scroll + focus on load, hash sync on toggle). - Keyboard support: Arrow Up/Down (wrapping), Home/End across visible headers - Collapsed panel content is unmounted (not just hidden) to avoid stale text for assistive tech and in-page search - Live region announces result-count changes on search - Covers long answers, empty search, empty entry list, unknown deep-link hash, dark mode, and RTL Adds 25 tests (100% line/function coverage on the component) and design-system documentation. Note: `npm run build` fails on main due to pre-existing issues unrelated to this change (theme-switcher.tsx default-export mismatch, dashboard-data.ts missing exports referenced by design-review/page.tsx). Verified this change introduces zero new lint or build errors. Closes Chronopay-Org#258
|
@KingDavid9999 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add SupplierFaqAccordion to the supplier profile, implementing the
WAI-ARIA disclosure pattern with searchable question/answer/category
matching, matched-term highlighting, and deep-linking via URL hash
(expand + scroll + focus on load, hash sync on toggle).
text for assistive tech and in-page search
hash, dark mode, and RTL
Adds 25 tests (100% line/function coverage on the component) and
design-system documentation.
Note:
npm run buildfails on main due to pre-existing issues unrelatedto this change (theme-switcher.tsx default-export mismatch,
dashboard-data.ts missing exports referenced by design-review/page.tsx).
Verified this change introduces zero new lint or build errors.
CI lint failure is pre-existing on main, unrelated to this change (34 errors across ~15 files not touched by this PR — parsing errors, missing component references, setState-in-effect violations).
Closes #258