Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ambiguous lsblk behaviour in LUKS/LVM use cases #253

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

olivermg
Copy link

Fixes #252

Adds

sed -r 's/^[^[:alnum:]]+//'

to relevant locations of lsblk usage in order to remove ambiguous behaviour in certain partition layouts (refer to issue #252 for more info).

Please double check this, as the use case that this patch has helped me with probably only used a certain portion of the patched lines. I've tried to fix this throughout all scripts (just found relevant lines in util-base.sh and util-disk.sh).

@Chrysostomus
Copy link
Owner

Thanks! However, the version on github is outdated, the development has moved to gitlab:

https://gitlab.manjaro.org/applications/manjaro-architect

If possible, could you provide the changes against that repo? Either way, I'll try to implement the fix once I get working hardware.

@olivermg
Copy link
Author

Sure, I'll file it over there :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Erroneous behaviour when using LVM on LUKS with certain partition layouts
2 participants