Created a motion weave asset and updated imgui to the newest version #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChunkTreasure1
requested changes
Jan 9, 2024
| case Volt::AssetType::MotionWeave: | ||
| { | ||
| UI::OpenModal("New Motion Weave Graph##assetBrowser"); | ||
| m_MotionWeaveTargetSkeleton = 0; |
| UI::EndProperties(); | ||
| } | ||
|
|
||
| const bool cantCreate = m_MotionWeaveTargetSkeleton == 0; |
There was a problem hiding this comment.
Should be compared to Asset::Null()
| if (ImGui::IsItemHovered(ImGuiHoveredFlags_AllowWhenDisabled)) | ||
| { | ||
| ImGui::BeginTooltip(); | ||
| if (m_MotionWeaveTargetSkeleton == 0) |
There was a problem hiding this comment.
Should be compared to Asset::Null()
| @@ -119,6 +120,9 @@ class AssetBrowserPanel : public EditorWindow | |||
| ///// Animation Graph creation ///// | |||
| NewAnimationGraphData myNewAnimationGraphData{}; | |||
|
|
|||
| ///// Motion Weave creation ///// | |||
| Volt::AssetHandle m_MotionWeaveTargetSkeleton = 0; | |||
| @@ -309,7 +309,6 @@ void ThemesPanel::SetMinecraftTheme() | |||
| style.Colors[ImGuiCol_ResizeGripActive] = ImVec4(0.4f, 0.67f, 1.000f, 1.000f); | |||
|
|
|||
| style.Colors[ImGuiCol_Tab] = ImVec4(0.137f, 0.137f, 0.137f, 1.000f); | |||
| style.Colors[ImGuiCol_TabTop] = ImVec4(0.4f, 0.67f, 1.000f, 1.000f); | |||
| { | ||
| MotionWeaveAssetEntry& entry = m_MotionWeaveAsset->GetMotionWeaveAssetEntries()[0]; | ||
|
|
||
| MotionWeaveEntry newEntry; |
There was a problem hiding this comment.
Could use emplace_back instead
There was a problem hiding this comment.
Might want to use YAMLStreamWriter & YAMLStreamReader instead
| @@ -195,7 +195,6 @@ namespace Volt | |||
| style.Colors[ImGuiCol_ResizeGripActive] = ImVec4(0.4f, 0.67f, 1.000f, 1.000f); | |||
|
|
|||
| style.Colors[ImGuiCol_Tab] = ImVec4(0.137f, 0.137f, 0.137f, 1.000f); | |||
| style.Colors[ImGuiCol_TabTop] = ImVec4(0.4f, 0.67f, 1.000f, 1.000f); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.