Fixed crash caused by key mismatch

[QueenPrinsessa]

relPath was added to "." while relPath.parent_path() could give "" causing an exception since there's no entry allocated for added for ""

[coderabbitai]

Walkthrough

The AssetDirectoryProcessor.cpp file has been updated to improve the handling of directory and asset relationships. The modifications ensure that the parent path is used correctly when organizing directories and assets. This change helps maintain accurate hierarchy and structure within the asset directory processing logic.

Changes

Files	Change Summary
Volt/Sandbox/src/Sandbox/Window/AssetBrowser/AssetDirectoryProcessor.cpp	Updated how directory and asset relationships are handled by using the correct parent path in ProcessDirectories.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant AssetDirectoryProcessor
    participant DirectoryItems
    participant ParentPath

    User->>AssetDirectoryProcessor: Invoke ProcessDirectories()
    AssetDirectoryProcessor->>DirectoryItems: Access directoryItems
    DirectoryItems->>ParentPath: Retrieve parentPath
    ParentPath-->>DirectoryItems: Return parentPath
    DirectoryItems->>AssetDirectoryProcessor: Update subDirectories and assets using parentPath

Loading

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ac449d7 and 08981e2.

Files selected for processing (1)

• Volt/Sandbox/src/Sandbox/Window/AssetBrowser/AssetDirectoryProcessor.cpp (2 hunks)

Additional comments not posted (7)

Volt/Sandbox/src/Sandbox/Window/AssetBrowser/AssetDirectoryProcessor.cpp (7)

58-58: Ensure the directory item is correctly inserted.

The directory item is being inserted into the directoryItems map using relPath. This change looks correct.

---

59-59: Ensure the parent path is correctly retrieved.

The parent path is being retrieved using Volt::AssetManager::GetRelativePath(entry.path.parent_path()). This change looks correct and addresses the key mismatch issue.

---

60-60: Ensure the sub-directory is correctly inserted.

The sub-directory is being inserted into the subDirectories vector of the parent directory item. This change looks correct.

---

61-61: Ensure the parent directory is correctly assigned.

The parent directory is being assigned to the parentDirectory member of dirData. This change looks correct.

---

78-78: Ensure the asset item is correctly created.

The asset item is being created using CreateRef<AssetBrowser::AssetItem>. This change looks correct.

---

79-79: Ensure the parent path is correctly retrieved.

The parent path is being retrieved using Volt::AssetManager::GetRelativePath(entry.path.parent_path()). This change looks correct and addresses the key mismatch issue.

---

80-80: Ensure the asset is correctly inserted.

The asset is being inserted into the assets vector of the parent directory item. This change looks correct.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.