Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(circles): introduce event DiscountCost #148

Merged
merged 6 commits into from
May 10, 2024
Merged

(circles): introduce event DiscountCost #148

merged 6 commits into from
May 10, 2024

Conversation

benjaminbollen
Copy link
Member

@benjaminbollen benjaminbollen commented May 3, 2024 •
edited
Loading

  • introduce event DiscountCost to make accounting easy for the value subtracted from discounting
  • update tests to trigger more discounting and validate correct events
  • ensure DiscountCost is equivalently added to ERC20, should/might be the case already - add tests to erc20 lift to assert

@benjaminbollen benjaminbollen linked an issue May 3, 2024 that may be closed by this pull request
Review events (ao DiscountCost) #146
Closed
2 tasks
@benjaminbollen
Copy link
Member Author

  • completed code for discount cost for ERC20
    todo: write tests for ERC20 discount cost

@benjaminbollen benjaminbollen force-pushed the 20240503-events-discountcost branch from 2d36f31 to ab09171 Compare May 8, 2024 17:27
@benjaminbollen benjaminbollen marked this pull request as ready for review May 8, 2024 17:28
jaensen
jaensen previously approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@jaensen jaensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jaensen
jaensen approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@jaensen jaensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaensen jaensen merged commit dea17c1 into develop May 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaensen jaensen jaensen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
circles-contracts-v2
Status: 💪Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review events (ao DiscountCost)
2 participants
@benjaminbollen @jaensen