Handle error in enum_users #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a blank response is received from rpcclient the data processing is skipped preventing errors.
|
Uninitialized value $users occurs when the rpcclient command does not receive anything in response. I've added a pull request to handle it but they can be safely ignored. It just means the command failed to find anything. The RID cycling can definitely be made more efficient/faster as well but maybe another time. Currently it just misses the important Unix UIDs and searches across known Windows SIDs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a blank response is received from rpcclient the data processing is skipped preventing errors.