Added firmware upgrade support for ucsm managed rack server. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…red the ucsfirmware module.
| # firmware_activate_blade( | ||
| # handle, version=version, | ||
| # require_user_confirmation=require_user_confirmation) | ||
| log.debug("Activating Firmware Rack......") |
There was a problem hiding this comment.
"Activating Firmware Rack" => "Activating Rack Firmware"
|
SGTM other than than the minor comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Able to perform firmware upgrade for ucsm managed rack server.
Restructured the ucsfirmware module.
Removed repetitive code.
Changed few function to internal.
changed raw_input to input method