Skip to content

Fixes TTL texture loading exceptions #732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
krzychu124 merged 1 commit into from
Feb 23, 2020
Merged

Fixes TTL texture loading exceptions #732

krzychu124 merged 1 commit into from
Feb 23, 2020

Conversation

@krzychu124
Copy link
Member

@krzychu124 krzychu124 commented Feb 23, 2020 •
edited
Loading

Closes #704

Introduced probably when @kvakvs was refactoring traffic light texture loader (not all texture files were moved) and we didn't spotted that under review 😕

On 99.9% fixes #714 too.

@krzychu124 krzychu124 added BUG Defect detected confirmed Represents confirmed issue or bug TRAFFIC LIGHTS Feature: Traffic lights - toggle, timed, etc labels Feb 23, 2020
@krzychu124 krzychu124 added this to the 11.1.1 milestone Feb 23, 2020
@krzychu124 krzychu124 self-assigned this Feb 23, 2020
@krzychu124 krzychu124 changed the title Fixes texture loading exceptions Fixes TTL texture loading exceptions Feb 23, 2020
@originalfoo
Copy link
Member

originalfoo commented Feb 23, 2020

Awesome catch! Will test this shortly.

I <3 bugfixes!!

@krzychu124
Copy link
Member Author

krzychu124 commented Feb 23, 2020

My goal was to go below 300 issues (little steps), but... it might be way harder than I thought 😄

@originalfoo
Copy link
Member

originalfoo commented Feb 23, 2020

If I can get the UI finished for #699 that will fix a big list of issues.

kvakvs
kvakvs approved these changes Feb 23, 2020
View reviewed changes
Copy link
Collaborator

@kvakvs kvakvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

originalfoo
originalfoo approved these changes Feb 23, 2020
View reviewed changes
Copy link
Member

@originalfoo originalfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in-game, LGTM 👍

@krzychu124 krzychu124 merged commit 37a340b into master Feb 23, 2020
@krzychu124 krzychu124 deleted the bugfix/704 branch February 24, 2020 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kvakvs kvakvs kvakvs approved these changes

@originalfoo originalfoo originalfoo approved these changes

Assignees

@krzychu124 krzychu124

Labels

BUG Defect detected confirmed Represents confirmed issue or bug TRAFFIC LIGHTS Feature: Traffic lights - toggle, timed, etc

Projects

None yet

Milestone

11.1.1

Development

Successfully merging this pull request may close these issues.

TTL texture issue, duplicate TTL scripts, and warning about mod conflict Texture errors in TMPE.log

4 participants

@krzychu124 @originalfoo @kvakvs