Skip to content

Conversation

@IvaKop
Copy link
Contributor

@IvaKop IvaKop commented Oct 27, 2025

Changelog

Changed

  • The user location will now be visible on the ideas map view provided the user gives location permission to the browser

@notion-workspace
Copy link

Add user location to map

@cl-dev-bot
Copy link
Collaborator

cl-dev-bot commented Oct 27, 2025

Messages
📖 Changelog provided 🎉
📖 Notion issue: TAN-5715
📖

Run the e2e tests

📖 Check translation progress

Generated by 🚫 dangerJS against bacb07c

@IvaKop
Copy link
Contributor Author

IvaKop commented Oct 27, 2025

@amanda-anderson A quick functional test would be appreciated for this one! Thanks 🙌

Copy link
Contributor

@amanda-anderson amanda-anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IvaKop From my functional test:

I didn't get the "Location Requested" permission popup when I loaded the page. I went into my browser settings instead though and enabled it there so I could test, which did make the location icon on the map appear. Not sure why it didn't ask me for permission though.

However the location is really far away from where I actually am in the city 🤔 I'm wondering if this only really makes sense for Mobile devices, where we can actually get an accurate result? Otherwise I don't find this super useful (and instead a bit confusing) on Desktop.

Also, the circle icon is quite similar to the Idea marker (especially if a client is using a blue branding colour). It's indeed a bit smaller, but I think users might potentially confuse them?

image

@IvaKop
Copy link
Contributor Author

IvaKop commented Oct 27, 2025

@amanda-anderson That's great, thanks for letting me know. For me, the location is really accurate and the popup appears with no issues so it's really useful to know it's not working so well for you. We will discuss it within the team and see where we go from there.

@IvaKop
Copy link
Contributor Author

IvaKop commented Oct 27, 2025

@amanda-anderson I implemented some changes based on your comments:

  • The location is now only available on tablet or smaller. Debated a bit whether to add actual device detection instead of basing this on the screen size but decided this is probably good enough for now and we can always change it, if we see it's creating issues
  • I changed the shape of the ideas on the map to triangle on smaller devices so that it doesn't look super similar to the location dot

I also tested this on my actual phone and for me it worked alright. Could you maybe do the same and see if you still have location issues. I made an epic deployment for this.

@amanda-anderson
Copy link
Contributor

@IvaKop Yes works much better on my mobile (gets the right location) 🚀

One thing I noticed is that when I selected an idea (triangle), the location circle disappeared:
IMG_2512
IMG_2511

Copy link
Contributor

@amanda-anderson amanda-anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left one comment from the functional review, but happy to approve in advance :)

@IvaKop
Copy link
Contributor Author

IvaKop commented Nov 6, 2025

@amanda-anderson Nice catch! Fixed it :)

@IvaKop IvaKop merged commit cc7737e into master Nov 6, 2025
16 checks passed
@IvaKop IvaKop deleted the TAN-5715-user-location branch November 6, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants