-
Notifications
You must be signed in to change notification settings - Fork 37
TAN-5715 User location on idea map #12373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
@amanda-anderson A quick functional test would be appreciated for this one! Thanks 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@IvaKop From my functional test:
I didn't get the "Location Requested" permission popup when I loaded the page. I went into my browser settings instead though and enabled it there so I could test, which did make the location icon on the map appear. Not sure why it didn't ask me for permission though.
However the location is really far away from where I actually am in the city 🤔 I'm wondering if this only really makes sense for Mobile devices, where we can actually get an accurate result? Otherwise I don't find this super useful (and instead a bit confusing) on Desktop.
Also, the circle icon is quite similar to the Idea marker (especially if a client is using a blue branding colour). It's indeed a bit smaller, but I think users might potentially confuse them?
|
@amanda-anderson That's great, thanks for letting me know. For me, the location is really accurate and the popup appears with no issues so it's really useful to know it's not working so well for you. We will discuss it within the team and see where we go from there. |
|
@amanda-anderson I implemented some changes based on your comments:
I also tested this on my actual phone and for me it worked alright. Could you maybe do the same and see if you still have location issues. I made an epic deployment for this. |
|
@IvaKop Yes works much better on my mobile (gets the right location) 🚀 One thing I noticed is that when I selected an idea (triangle), the location circle disappeared: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Left one comment from the functional review, but happy to approve in advance :)
|
@amanda-anderson Nice catch! Fixed it :) |


Changelog
Changed