TAN-5763 JWT token data tool #12427
Merged
TAN-5763 JWT token data tool #12427
+39
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
sebastienhoorens
commented
Nov 3, 2025
| jwt_token = json_parse(response_body)[:jwt_token] | ||
|
|
||
| # Test JWT structure (payloads starting with "{" will always start with "eyJ" when encoded) | ||
| expect(jwt_token).to match(/\AeyJ[A-Za-z0-9_-]+\.[A-Za-z0-9_-]+\.[A-Za-z0-9_-]+\z/) |
Contributor
Author
There was a problem hiding this comment.
Regex generated with Copilot.
jinjagit
reviewed
Nov 4, 2025
back/app/services/user_service.rb
Outdated
| user.save! | ||
| end | ||
|
|
||
| def jwt_token(user) |
Contributor
There was a problem hiding this comment.
Maybe rename this method (&/or add a comment) to make it clear what the use case is, as I expect other devs would get confused about which JWT token in used in the the 'regular' requests.
Contributor
Author
There was a problem hiding this comment.
Good point, for some reason I thought this was a separate service within the admin API engine, but seems like I didn't see that right. I'll rename it or move it somewhere else. Or add a comment indeed.
jinjagit
approved these changes
Nov 4, 2025
Contributor
jinjagit
left a comment
jinjagit
left a comment
There was a problem hiding this comment.
Just a suggestion to disambiuguate the new jwt token generation method from the existing one(s)
sebastienhoorens
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Added