Exclude M and Z values in shape when extracting from Oracle, and make S3 upload optional #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floptical
force-pushed
the
mz_fix-10-9-2024
branch
from
0324bff
to
cd16ee6
Compare
|
Actions failing because of commenting out these lines I think, otherwise the actions are successful: self.times_db_called = data.times_db_called We don't care about this anymore in Oracle because we're the only ones on the Oracle server. Merging this anyway because I really need it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a fancy function to modify petl after extracted to remove M or Z values.
Additionally, make S3 uploads optional. If not --s3_key and --s3_bucket are not specified, the CSV will be saved to the working directory.