Implement accessible radix tabs in V2 components #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…red sorting happens in components.
…tablet breakpoint.
This reverts commit 64f2e9596d69fae194741937eb85833a3eff5197.
…c, to keep track of differences.
patcon
force-pushed
the
implement-radix-tabs
branch
from
add8614
to
e4c7ffd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works towards making hte V2 selection components more accessible, part of #4
This builds on #16
It add
isAccessibleflags to the relevant components, so that the impact of the changes can be easily reviewedDemo: https://civictechto.github.io/polis-storybook/PR-17/?path=/story/compdem-client-participation-civictechto-selectionwidgetv2--interactive&globals=viewport:mobile1