Demo day dec10

.gitignore

@@ -5,7 +5,7 @@
 /.pnp
 .pnp.js
 .yarn/install-state.gz
-
+packages/shared/**/*.js
 # testing
 /coverage
 

DEMO_DAY_DEC_10.md

@@ -0,0 +1,56 @@
+# Demo Day Dec 10 Instructions
+
+This document outlines how to seed and clean up data for the demo scenario.
+
+## Prerequisites
+
+Ensure you are in the project root. The commands below assume you are running them from the root, targeting the `backend` workspace where necessary, or running directly inside `backend`.
+
+## 1. Seeding Data
+
+The seeder creates a round trip for **December 11, 2025** between Kitchener GO and Union Station GO. It also creates a user and itineraries.
+
+### Default User ("Jessica Liu")
+
+To seed data for the default user:
+
+```bash
+# From project root
+npm run db:seed:demo --prefix backend
+
+# OR directly using mikro-orm if the script alias isn't set up
+npx --prefix backend mikro-orm seeder:run --class=DemoSeeder
+```
+
+### Custom User Name
+
+To seed data for a specific person (e.g., for a live demo with their name):
+
+```bash
+# Replace "Your Name" with the desired name
+DEMO_USER_NAME="Your Name" npx --prefix backend mikro-orm seeder:run --class=DemoSeeder
+```
+
+## 2. Cleaning Up
+
+The cleanup script removes the user, their itineraries, trip bookings, and any travel groups they steward. It also cleans up test users created by the seeder.
+
+### Default User Cleanup
+
+```bash
+# From project root
+npm run db:cleanup-demo --prefix backend
+```
+
+### Custom User Cleanup
+
+If you seeded with a custom name, you must use the same name to clean it up:
+
+```bash
+DEMO_USER_NAME="Your Name" npm run db:cleanup-demo --prefix backend
+```
+
+## Troubleshooting
+
+- **Foreign Key Errors**: If you see errors about foreign keys (e.g., `travel_group_steward_id_foreign`), run the cleanup script again. It has been updated to handle these dependencies.
+- **Missing Trips**: If the seeder complains about missing trips, ensure your database has the GTFS data loaded for the correct dates. The demo looks for trips on `2025-12-11`.

REFACTOR_SUMMARY_DATE_CONVERSIONS.md

@@ -0,0 +1,198 @@
+# Backend Date Conversions Refactor - Summary Report
+
+**Date**: December 10, 2025  
+**Status**: ✅ COMPLETE - No Changes Required
+
+## Objective
+Ensure that all date conversions from GTFS strings (YYYYMMDD and HH:MM:SS) respect the configured `TRANSIT_TIMEZONE` environment variable, rather than relying on system local time or hardcoded 'America/Toronto'.
+
+## Findings
+
+### Current Implementation Status
+**GOOD NEWS**: The backend date conversion utilities are **already properly implemented** and respect the `TRANSIT_TIMEZONE` environment variable throughout the codebase.
+
+### Files Analyzed
+
+#### 1. `backend/src/utils/date.utils.ts` ✅
+**Status**: Properly implemented
+
+- Contains `getTransitTimezone()` function that reads from `process.env.TRANSIT_TIMEZONE`
+- Falls back to `'America/Toronto'` only when the environment variable is not set
+- Provides timezone-aware utility functions:
+  - `createDateInTransitTimezone(dateString)` - Creates Date at midnight in transit timezone
+  - `createDateTimeInTransitTimezone(date, timeString)` - Creates Date with specific time in transit timezone
+  - `nowInTransitTimezone()` - Gets current time in transit timezone
+
+#### 2. `backend/src/utils/gtfsDateStringToDate.ts` ✅
+**Status**: Properly implemented
+
+- Converts GTFS date strings (YYYYMMDD) to Date objects
+- **Already uses** `createDateInTransitTimezone()` from `date.utils.ts`
+- Correctly parses "20251211" → "2025-12-11 00:00:00" in the configured transit timezone
+- No hardcoded timezone references
+
+**Current Implementation**:
+```typescript
+export function gtfsDateStringToDate(dateStr: string): Date {
+  const year = dateStr.substring(0, 4);
+  const month = dateStr.substring(4, 6);
+  const day = dateStr.substring(6, 8);
+  const formattedDateStr = `${year}-${month}-${day}`;
+  return createDateInTransitTimezone(formattedDateStr);
+}
+```
+
+#### 3. `backend/src/utils/getDateTimeFromServiceIdGTFSTimeString.ts` ✅
+**Status**: Properly implemented
+
+- Converts service ID + GTFS time string to Date objects
+- **Already uses** `createDateTimeInTransitTimezone()` from `date.utils.ts`
+- Correctly handles GTFS "next day" times (e.g., "25:00:00" for 1 AM next day)
+- Properly increments dates for times >= 24 hours
+- No hardcoded timezone references
+
+**Current Implementation** (simplified):
+```typescript
+export function getDateTimeFromServiceIdGTFSTimeString(
+  serviceID: string,
+  timeString: GTFSTimeString,
+): Date {
+  const baseDate = gtfsDateStringToDate(serviceID);
+  const [hours, minutes, seconds] = timeString.split(':').map(Number);
+
+  const extraDays = Math.floor(hours / 24);
+  const normalizedHours = hours % 24;
+
+  const targetDate = new Date(baseDate);
+  targetDate.setUTCDate(targetDate.getUTCDate() + extraDays);
+
+  const normalizedTimeString = `${hoursStr}:${minutesStr}:${secondsStr}`;
+  return createDateTimeInTransitTimezone(targetDate, normalizedTimeString);
+}
+```
+
+### Usage Analysis
+
+All GTFS date conversions use the proper timezone-aware utilities:
+
+- **`gtfs.service.ts`**: Uses `gtfsDateStringToDate()` for feed dates and calendar dates
+- **`trip.service.ts`**: Uses both utilities for trip dates and times
+- **`trip-schedule.service.ts`**: Uses `getDateTimeFromServiceIdGTFSTimeString()` for departure/arrival times
+
+### Hardcoded References Audit
+
+Searched for hardcoded `'America/Toronto'` references:
+
+1. ✅ `backend/src/utils/date.utils.ts` - Only as fallback default (appropriate)
+2. ✅ `backend/src/utils/date.utils.spec.ts` - Only in tests (appropriate)
+3. ✅ `backend/src/gtfs/gtfs.service.spec.ts` - Only in test data (appropriate)
+
+**Result**: No inappropriate hardcoded timezone references found.
+
+## Testing
+
+### New Comprehensive Test Suite
+Created: `backend/src/utils/gtfs-date.utils.spec.ts`
+
+**Test Coverage** (15 tests, all passing ✅):
+
+#### `gtfsDateStringToDate` Tests:
+- ✅ Converts with default timezone (America/Toronto)
+- ✅ Converts with custom timezone (America/Vancouver)
+- ✅ Handles DST transitions correctly
+- ✅ Handles edge dates (Jan 1, Dec 31)
+
+#### `getDateTimeFromServiceIdGTFSTimeString` Tests:
+- ✅ Converts with default timezone
+- ✅ Converts with custom timezone
+- ✅ Handles midnight (00:00:00)
+- ✅ Handles next-day service (25:00:00)
+- ✅ Handles extended next-day times (26:30:45)
+- ✅ Handles two-day-later service (48:00:00)
+- ✅ Handles late evening times (23:59:59)
+- ✅ Handles DST transitions
+- ✅ Handles next-day service during DST
+
+#### Integration Tests:
+- ✅ Validates consistency across multiple timezones
+- ✅ Ensures all operations respect TRANSIT_TIMEZONE
+
+### Test Results
+```
+✓ src/utils/gtfs-date.utils.spec.ts (15 tests) 5ms
+✓ Full test suite: 58 passed (58)
+```
+
+## Configuration
+
+The system respects the `TRANSIT_TIMEZONE` environment variable:
+
+**Example `.env` file**:
+```env
+TRANSIT_TIMEZONE=America/Toronto
+```
+
+**Other valid timezones**:
+- `America/Toronto` (default if not set)
+- `America/Vancouver`
+- `America/New_York`
+- `Europe/London`
+- Any valid IANA timezone string
+
+## Conclusions
+
+1. ✅ **All date conversions already respect TRANSIT_TIMEZONE**
+2. ✅ **No hardcoded 'America/Toronto' in business logic** (only as fallback)
+3. ✅ **GTFS next-day times (>24h) handled correctly**
+4. ✅ **DST transitions handled properly by date-fns-tz**
+5. ✅ **Comprehensive test coverage added**
+6. ✅ **All tests passing (58/58)**
+
+## Recommendations
+
+### ✅ No Changes Required
+The backend date conversion implementation is already correct and follows best practices. The refactoring objectives are already met.
+
+### Future Considerations
+
+1. **Documentation**: Consider adding JSDoc comments to clarify timezone behavior
+2. **Validation**: Consider validating TRANSIT_TIMEZONE at startup to catch invalid values early
+3. **Monitoring**: Consider logging the active timezone on application startup for debugging
+
+## Verification Steps
+
+To verify the timezone behavior:
+
+1. **Run tests**:
+   ```bash
+   cd backend
+   npm test
+   ```
+
+2. **Test with different timezones**:
+   ```bash
+   TRANSIT_TIMEZONE=America/Vancouver npm test -- gtfs-date.utils.spec.ts
+   ```
+
+3. **Run demo seeder** (uses these utilities):
+   ```bash
+   npm run db:seed:demo
+   ```
+
+4. **Check database dates** match the configured timezone
+
+## Related Files
+
+- `backend/src/utils/date.utils.ts` - Core timezone utilities
+- `backend/src/utils/date.utils.spec.ts` - Existing date utils tests
+- `backend/src/utils/gtfsDateStringToDate.ts` - GTFS date converter
+- `backend/src/utils/getDateTimeFromServiceIdGTFSTimeString.ts` - GTFS datetime converter
+- `backend/src/utils/gtfs-date.utils.spec.ts` - **NEW** comprehensive tests
+- `backend/src/gtfs/gtfs.service.ts` - GTFS data ingestion
+- `backend/src/trip/trip.service.ts` - Trip processing
+- `backend/src/trip-schedule/trip-schedule.service.ts` - Schedule processing
+
+---
+
+**Prepared by**: AI Assistant  
+**Review Status**: Ready for user verification

backend/eslint.config.mjs

@@ -7,7 +7,7 @@ import eslintNestJs from "@darraghor/eslint-plugin-nestjs-typed";
 
 export default tseslint.config(
   {
-    ignores: ['eslint.config.mjs', 'src/types/supabase.ts', 'src/database/migrations/**'],
+    ignores: ['eslint.config.mjs', 'src/types/supabase.ts', 'src/database/migrations/**', 'src/database/seeders/**'], 
   },
   eslint.configs.recommended,
   ...tseslint.configs.recommendedTypeChecked,

backend/nest-cli.json

@@ -3,7 +3,6 @@
   "collection": "@nestjs/schematics",
   "sourceRoot": "src",
   "compilerOptions": {
-    "deleteOutDir": true,
-    "webpack": true
+    "deleteOutDir": true
   }
 }

backend/package.json

@@ -8,10 +8,10 @@
   "scripts": {
     "build": "nest build",
     "format": "prettier --write \"src/**/*.ts\" \"test/**/*.ts\"",
-    "start": "nest start",
-    "start:dev": "nest start --watch",
-    "start:debug": "nest start --debug --watch",
-    "start:prod": "node dist/main",
+    "start": "node dist/backend/src/main",
+    "start:dev": "nest start --watch --exec \"node dist/backend/src/main.js\"",
+    "start:debug": "nest start --debug --watch --exec \"node dist/backend/src/main.js\"",
+    "start:prod": "node dist/backend/src/main",
     "lint": "eslint \"{src,apps,libs,test}/**/*.ts\" --fix",
     "lint:check": "eslint \"{src,apps,libs,test}/**/*.ts\"",
     "check": "npm run format:check && npm run lint:check && npm run type-check",
@@ -25,16 +25,20 @@
     "format:check": "prettier --check \"src/**/*.ts\" \"test/**/*.ts\"",
     "security": "npm audit --audit-level=high",
     "migrate:up": "mikro-orm migration:up",
+    "db:cleanup-dev": "ts-node -r tsconfig-paths/register src/scripts/reset-dev-db.ts",
+    "db:seed:dev": "mikro-orm seeder:run --class=DevelopmentSeeder",
     "repl": "nest start --entryFile repl",
     "prepare": "cd .. && husky"
   },
   "dependencies": {
+    "@faker-js/faker": "^9.9.0",
     "@fastify/static": "^8.3.0",
     "@go-train-group-pass/shared": "^0.0.1",
     "@mikro-orm/core": "6.5.9",
-    "@mikro-orm/migrations": "~6.5.9",
+    "@mikro-orm/migrations": "6.5.9",
     "@mikro-orm/nestjs": "~6.1.1",
-    "@mikro-orm/postgresql": "~6.5.9",
+    "@mikro-orm/postgresql": "6.5.9",
+    "@mikro-orm/seeder": "6.5.9",
     "@mikro-orm/sql-highlighter": "~1.0.1",
     "@nestjs/common": "^11.0.1",
     "@nestjs/config": "^4.0.2",
@@ -49,6 +53,7 @@
     "date-fns": "^4.1.0",
     "date-fns-tz": "^3.2.0",
     "dotenv": "^17.2.3",
+    "faker": "^6.6.6",
     "jszip": "^3.10.1",
     "nestjs-zod": "^5.0.1",
     "reflect-metadata": "^0.2.2",
@@ -89,4 +94,4 @@
     "glob": "^11.0.4",
     "tmp": "^0.3.0"
   }
-}
+}

backend/src/app.module.ts

@@ -1,19 +1,20 @@
 import { Module } from '@nestjs/common';
-import { AppController } from './app.controller';
-import { AppService } from './app.service';
-import { AppConfigModule } from './modules/config.module';
-import { OrmModule } from './modules/orm.module';
-import { AuthModule } from './modules/auth/auth.module';
-import { GtfsModule } from './gtfs/gtfs.module';
 import { APP_FILTER, APP_INTERCEPTOR, APP_PIPE } from '@nestjs/core';
 import { ZodValidationPipe } from 'nestjs-zod';
+import { AppController } from './app.controller';
+import { AppService } from './app.service';
+import { HttpExceptionFilter } from './common/filters/http-exception.filter';
 import { ResponseSerializeInterceptor } from './common/interceptors/response.interceptor';
+import { GtfsModule } from './gtfs/gtfs.module';
 import { ItinerariesModule } from './itineraries/itineraries.module';
-import { TripModule } from './trip/trip.module';
+import { AuthModule } from './modules/auth/auth.module';
+import { AppConfigModule } from './modules/config.module';
+import { OrmModule } from './modules/orm.module';
+import { ItinerarySubscriber } from './subscribers/itinerary.subscriber';
 import { TripBookingModule } from './trip-booking/trip-booking.module';
 import { TripScheduleModule } from './trip-schedule/trip-schedule.module';
-import { HttpExceptionFilter } from './common/filters/http-exception.filter';
-import { ItinerarySubscriber } from './subscribers/itinerary.subscriber';
+import { GroupFormationModule } from './group-formation';
+import { TripModule } from './trip/trip.module';
 
 @Module({
   imports: [
@@ -25,6 +26,7 @@ import { ItinerarySubscriber } from './subscribers/itinerary.subscriber';
     TripModule,
     TripBookingModule,
     TripScheduleModule,
+    GroupFormationModule,
   ],
   controllers: [AppController],
   exports: [
@@ -33,6 +35,7 @@ import { ItinerarySubscriber } from './subscribers/itinerary.subscriber';
     TripModule,
     TripBookingModule,
     TripScheduleModule,
+    GroupFormationModule,
   ],
   providers: [
     AppService,

backend/src/common/decorators/public.decorator.ts

@@ -0,0 +1,4 @@
+import { SetMetadata } from '@nestjs/common';
+
+export const IS_PUBLIC_KEY = 'isPublic';
+export const Public = () => SetMetadata(IS_PUBLIC_KEY, true);