feat!(API): add callback(result) to lua API #246
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I add callback(result) as the last parameter to most API calls, and:
Result
type: itsnew
method was setting attributes on the class instead of the objectTypes
type:SUCCESS
was1
when there are places in code that assume that it is 0I tested this locally - to an extent, let me know if there is some kind of proper procedure to know it's working.
RESOLVES: #245