build-llvm.py: Utilize LLVM_DISTRIBUTION_COMPONENTS to build fewer targets #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaskRay
requested review from
msfjarvis,
nathanchance,
nickdesaulniers and
stephenhines
as code owners
MaskRay
requested review from
nathanchance
and removed request for
nathanchance
…rgets `build/llvm/bootstrap/bin/` contains a lot of LLVM and Clang tools that are not needed to build the kernel or later stages of Clang. Utilize LLVM_DISTRIBUTION_COMPONENTS to build fewer targets for 'bootstrap' and 'instrumented'. The `final` directory still contains everything. When BOLT is disabled, we now just build the following executables: ``` % ls build/llvm/bootstrap/bin/ clang@ clang-cpp@ llvm-ar* llvm-objcopy* llvm-readelf@ wasm-ld@ clang++@ clang-tblgen* llvm-lit* llvm-objdump* llvm-readobj* ld64.lld@ clang-18* lld* llvm-min-tblgen* llvm-profdata* llvm-strip@ ld.lld@ clang-cl@ lld-link@ llvm-nm* llvm-ranlib@ llvm-tblgen* ``` Tested: ./build-llvm.py --install-folder $PWD/install --projects clang lld --show-build-commands --targets X86 --pgo kernel-defconfig ./build-llvm.py --install-folder $PWD/install --projects clang lld --show-build-commands --targets X86 --pgo kernel-defconfig --bolt
MaskRay
force-pushed
the
slim-bootstrap
branch
from
904b4ba
to
638ffda
Compare
nathanchance
approved these changes
Sep 22, 2023
…lvm-objcopy;llvm-objdump;llvm-readelf;llvm-strip to a list
msfjarvis
approved these changes
Sep 23, 2023
nathanchance
added a commit
to nathanchance/tc-build
that referenced
this pull request
Oct 2, 2023
… building runtimes In the instrumented stage of the LLVM build when performing PGO, we set LLVM_BUILD_RUNTIME to OFF, as recommended by the LLVM documentation: https://llvm.org/docs/HowToBuildWithPGO.html#building-clang-with-pgo This breaks adding 'profile' to the distribution components, which was done in ClangBuiltLinux#243, as shown by the following cmake error: $ build-llvm.py \ --llvm-folder . \ --pgo kernel-defconfig \ --projects clang compiler-rt lld \ --targets X86 ... CMake Error at cmake/modules/LLVMDistributionSupport.cmake:276 (message): Specified distribution component 'profile' doesn't have an install target Call Stack (most recent call first): CMakeLists.txt:1340 (llvm_distribution_add_targets) CMake Error at cmake/modules/LLVMDistributionSupport.cmake:284 (message): Specified distribution component 'profile' doesn't have an install-stripped target. Its installation target creation should be changed to use add_llvm_install_targets, or you should manually create the 'install-profile-stripped' target. Call Stack (most recent call first): CMakeLists.txt:1340 (llvm_distribution_add_targets) compiler-rt is only included when LLVM_BUILD_RUNTIME is ON, so don't include the 'llvm-profdata' and 'profile' targets when LLVM_BUILD_RUNTIME is OFF. Signed-off-by: Nathan Chancellor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build/llvm/bootstrap/bin/contains a lot of LLVM and Clang tools that are not needed to build the kernel or later stages of Clang. Utilize LLVM_DISTRIBUTION_COMPONENTS to build fewer targets for 'bootstrap' and 'instrumented'. Thefinaldirectory still contains everything.When BOLT is disabled, we now just build the following executables:
Tested:
./build-llvm.py --install-folder $PWD/install --projects clang lld --show-build-commands --targets X86 --pgo kernel-defconfig