Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to ignoring messages. #598

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

rdebath
Copy link
Contributor

@rdebath rdebath commented Apr 22, 2021

Three commits ...
The first adds /ignore none to untick all flag style ignores.
The second adds a message to /ignore list if you're ignoring nothing what so ever.

The third adds more messages to the list suppressed by Ignores.DrawOutput in the classes:

Already shown by prompt.
    "Place or break two blocks to determine the edges."

No news is good news.
    "Created a new " + scope + " custom block"...
    "Duplicated the {0} custom block "...
    "Copied the {0} custom block "...

Some errors where the end results is what you wanted anyway are suppressed,  
For example, a missing block definition for block definition remove command is not show.

@Goodlyay
Copy link
Collaborator

/ignore none seems to imply that it also unignores all players you may have ignored, which it doesn't. Confusing name.
Blockdefinition messages are not appropriate to be suppressed when ignoring drawoutput. If that is desired, another flag should be made.
"Place or break two blocks to determine the edges." may be okay to suppress, but only if you can see the right-side text fields that show you are currently doing a draw op. (check if player supports CPE messages)

@rdebath
Copy link
Contributor Author

rdebath commented Apr 22, 2021

Can you suggest a better name for /ignore none ?

It's really easy to spam blockdefinition messages so fast they break the chatbox so yes they need to go. How about /ignore blockdef ?

CPE Messages, okay, I don't see a flag for that is it under p.hasCpe or a side effect of p.hasCP437

@Goodlyay
Copy link
Collaborator

A better name doesn't come to mind at the moment, but I'm also not sure why the option is even necessary since there aren't too many flags to begin with.
ignore blockdef seems ok
You can use p.Supports(CpeExt.MessageTypes) to check if they can receive bottom right/top right/announcement messages.

@rdebath
Copy link
Contributor Author

rdebath commented Apr 22, 2021

There aren't may flags, but there's no way to reliably turn them on or off.
All you can do is toggle them, half a second later your chatbox is broken any you have to close ClassiCube (not just disconnect) to fix it.
I considered adding an optional on/off flag on the end of the command, but the irc nicks break that idea.
I suppose the simple fix is to do as you request and clear the player lists too.

@UnknownShadow200
Copy link
Collaborator

What exactly do you mean by that your chatbox becomes broken and that you are required to close the game to fix the issue?

@Goodlyay
Copy link
Collaborator

“All you can do is toggle them, half a second later your chatbox is broken any you have to close ClassiCube (not just disconnect) to fix it.”
What does this mean? How is the chatbox broken? If turning off toggles is literally breaking the client, then adding another option to turn them all off at once is not addressing the actual issue here.

@rdebath
Copy link
Contributor Author

rdebath commented Apr 22, 2021

If you send too many messages to ClassiCube it's chatbox will break.
Firstly sending more than a couple of dozen messages at once obviously isn't useful.

But to actually break it you create a medium sized messagebox, I'd guess maybe a thousand commands, each of which sends a chatty message or two. You'll need to turn off the command spam check (and maybe the block spam). By the end of it the chat box has random slices of previously sent text displayed. I'd say it looks like a ring buffer has overflowed and it's pointers have got misaligned. Classicube doesn't as a whole doesn't crash but the chatbox stays broken until the program is restarted.

@Goodlyay
Copy link
Collaborator

that does sound like a genuine clientside issue, but what does it have to do with ignore toggles though? and how and why are you creating message boxes (i assume you mean message blocks) with thousands of commands inside?

@rdebath
Copy link
Contributor Author

rdebath commented Apr 22, 2021

For something like this I need to reliably turn off the chattering of the various commands even if the client doesn't break 100's of almost identical messages are not useful. I can't do that if all the message block can do is toggle them.

How: I'm just using a sendcmd from the console like this:

/sendcmd BobTheBuilder+ mb black /mb air :-( |/m 0 0 0 |/ignore none |/ignore drawoutput |/abort |/brush normal |/os env weather |/os env cloudheight |/os env preset normal |/os env horizon |/os env border |/os env edgelevel 2 |/os env sidesoffset |/os env cloudheight 1024 |/z walls 1 |/m 10 2 10 |/m 58 3 96 |/z 1 |/m 11 2 11 |/m 57 y 95 |/z 2 |/m 11 3 11 |/m 57 y 95 |/z DarkGrass |/m 11 3 11 |/m 57 y 95 |/z 52 |/m 14 3 14 |/m 54 y 92 |/z 0 |/m 10 4 10 |/m 58 20 96 |/z walls Op_Cobblestone |/m 10 2 10 |/m 58 3 96 |/z Opsidian |/m 11 2 11 |/m 57 y 95 |/z walls Glass |/m 13 4 13 |/m 55 5 93 |/z walls Op_Air |/m 10 4 10 |/m 58 20 96 |/z Op_Air |/m 11 20 11 |/m 57 y 95 |/pl 25 15 3 15 |/pl 1 15 5 15 |/pl 25 17 3 15 |/pl 2 17 5 15 |/pl 25 19 3 15 |/pl 3 19 5 15 |/pl 25 21 3 15 |/pl 4 21 5 15 |/pl 25 23 3 15 |/pl 5 23 5 15 |/pl 25 25 3 15 |/pl 6 25 5 15 |/pl 25 27 3 15 |/pl 7 27 5 15 |/z 20 |/m 28 4 14 |/m 30 5 16 |/pl 0 29 4 15 |/pl 25 29 3 15 |/pl 8 29 5 15 |/z 20 |/m 30 4 14 |/m 32 5 16 |/pl 0 31 4 15 |/pl 25 31 3 15 |/pl 9 31 5 15 |/z 20 |/m 32 4 14 |/m 34 5 16 |/pl 0 33 4 15 |/pl 25 33 3 15 |/pl 10 33 5 15 |/z 20 |/m 34 4 14 |/m 36 5 16 |/pl 0 35 4 15 |/pl 25 35 3 15 |/pl 11 35 5 15 |/pl 25 37 3 15 |/pl 12 37 5 15 |/pl 25 39 3 15 |/pl 13 39 5 15 |/pl 25 41 3 15 |/pl 14 41 5 15 |/pl 25 43 3 15 |/pl 15 43 5 15 |/pl 25 45 3 15 |/pl 16 45 5 15 |/pl 25 47 3 15 |/pl 17 47 5 15 |/pl 25 49 3 15 |/pl 18 49 5 15 |/pl 25 51 3 15 |/pl 19 51 5 15 |/pl 25 53 3 15 |/pl 20 53 5 15 |/pl 25 15 3 17 |/pl 21 15 5 17 |/pl 25 17 3 17 |/pl 22 17 5 17 |/pl 25 19 3 17 |/pl 23 19 5 17 |/pl 25 21 3 17 |/pl 24 21 5 17 |/pl 25 23 3 17 |/pl 25 23 5 17 |/pl 25 25 3 17 |/pl 26 25 5 17 |/pl 25 27 3 17 |/pl 27 27 5 17 |/pl 25 29 3 17 |/pl 28 29 5 17 |/pl 25 31 3 17 |/pl 29 31 5 17 |/pl 25 33 3 17 |/pl 30 33 5 17 |/pl 25 35 3 17 |/pl 31 35 5 17 |/pl 25 37 3 17 |/pl 32 37 5 17 |/pl 25 39 3 17 |/pl 33 39 5 17 |/pl 25 41 3 17 |/pl 34 41 5 17 |/pl 25 43 3 17 |/pl 35 43 5 17 |/pl 25 45 3 17 |/pl 36 45 5 17 |/pl 25 47 3 17 |/pl 37 47 5 17 |/pl 25 49 3 17 |/pl 38 49 5 17 |/pl 25 51 3 17 |/pl 39 51 5 17 |/pl 25 53 3 17 |/pl 40 53 5 17 |/pl 25 15 3 19 |/pl 41 15 5 19 |/pl 25 17 3 19 |/pl 42 17 5 19 |/pl 25 19 3 19 |/pl 43 19 5 19 |/pl 25 21 3 19 |/pl 44 21 5 19 |/pl 25 23 3 19 |/pl 45 23 5 19 |/pl 25 25 3 19 |/pl 46 25 5 19 |/pl 25 27 3 19 |/pl 47 27 5 19 |/pl 25 29 3 19 |/pl 48 29 5 19 |/pl 25 31 3 19 |/pl 49 31 5 19 |/pl 27 33 3 19 |/pl 50 33 5 19 |/pl 27 35 3 19 |/pl 51 35 5 19 |/pl 27 37 3 19 |/pl 52 37 5 19 |/pl 27 39 3 19 |/pl 53 39 5 19 |/pl 27 41 3 19 |/pl 54 41 5 19 |/pl 27 43 3 19 |/pl 55 43 5 19 |/pl 27 45 3 19 |/pl 56 45 5 19 |/pl 27 47 3 19 |/pl 57 47 5 19 |/pl 27 49 3 19 |/pl 58 49 5 19 |/pl 27 51 3 19 |/pl 59 51 5 19 |/pl 27 53 3 19 |/pl 60 53 5 19 |/pl 27 15 3 21 |/pl 61 15 5 21 |/pl 27 17 3 21 |/pl 62 17 5 21 |/pl 27 19 3 21 |/pl 63 19 5 21 |/pl 27 21 3 21 |/pl 64 21 5 21 |/pl 27 23 3 21 |/pl 65 23 5 21 |/pl 66 25 5 21 |/pl 67 27 5 21 |/pl 68 29 5 21 |/pl 69 31 5 21 |/pl 70 33 5 21 |/pl 71 35 5 21 |/pl 72 37 5 21 |/pl 73 39 5 21 |/pl 74 41 5 21 |/pl 75 43 5 21 |/pl 76 45 5 21 |/pl 77 47 5 21 |/pl 78 49 5 21 |/pl 79 51 5 21 |/pl 80 53 5 21 |/pl 81 15 5 23 |/pl 82 17 5 23 |/pl 83 19 5 23 |/pl 84 21 5 23 |/pl 85 23 5 23 |/pl 86 25 5 23 |/pl 87 27 5 23 |/pl 88 29 5 23 |/pl 89 31 5 23 |/pl 90 33 5 23 |/pl 91 35 5 23 |/pl 92 37 5 23 |/pl 93 39 5 23 |/pl 94 41 5 23 |/pl 95 43 5 23 |/pl 96 45 5 23 |/pl 97 47 5 23 |/pl 98 49 5 23 |/pl 99 51 5 23 |/pl 100 53 5 23 |/pl 101 15 5 25 |/pl 102 17 5 25 |/pl 103 19 5 25 |/pl 104 21 5 25 |/pl 105 23 5 25 |/pl 106 25 5 25 |/pl 107 27 5 25 |/pl 108 29 5 25 |/pl 109 31 5 25 |/pl 110 33 5 25 |/pl 111 35 5 25 |/pl 112 37 5 25 |/pl 113 39 5 25 |/pl 114 41 5 25 |/pl 115 43 5 25 |/pl 116 45 5 25 |/pl 117 47 5 25 |/pl 118 49 5 25 |/pl 119 51 5 25 |/pl 120 53 5 25 |/pl 121 15 5 27 |/pl 122 17 5 27 |/pl 123 19 5 27 |/pl 124 21 5 27 |/pl 125 23 5 27 |/pl 126 25 5 27 |/pl 127 27 5 27 |/pl 128 29 5 27 |/pl 129 31 5 27 |/pl 130 33 5 27 |/pl 131 35 5 27 |/pl 132 37 5 27 |/pl 133 39 5 27 |/pl 134 41 5 27 |/pl 135 43 5 27 |/pl 136 45 5 27 |/pl 137 47 5 27 |/pl 138 49 5 27 |/pl 139 51 5 27 |/pl 140 53 5 27 |/pl 141 15 5 29 |/pl 142 17 5 29 |/pl 143 19 5 29 |/pl 144 21 5 29 |/pl 145 23 5 29 |/pl 146 25 5 29 |/pl 147 27 5 29 |/pl 148 29 5 29 |/pl 149 31 5 29 |/pl 150 33 5 29 |/pl 151 35 5 29 |/pl 152 37 5 29 |/pl 153 39 5 29 |/pl 154 41 5 29 |/pl 155 43 5 29 |/pl 156 45 5 29 |/pl 157 47 5 29 |/pl 158 49 5 29 |/pl 159 51 5 29 |/pl 160 53 5 29 |/pl 161 15 5 31 |/pl 162 17 5 31 |/pl 163 19 5 31 |/pl 164 21 5 31 |/pl 165 23 5 31 |/pl 166 25 5 31 |/pl 167 27 5 31 |/pl 168 29 5 31 |/pl 169 31 5 31 |/pl 170 33 5 31 |/pl 171 35 5 31 |/pl 172 37 5 31 |/pl 173 39 5 31 |/pl 174 41 5 31 |/pl 175 43 5 31 |/pl 176 45 5 31 |/pl 177 47 5 31 |/pl 178 49 5 31 |/pl 179 51 5 31 |/pl 180 53 5 31 |/pl 181 15 5 33 |/pl 182 17 5 33 |/pl 183 19 5 33 |/pl 184 21 5 33 |/pl 185 23 5 33 |/pl 186 25 5 33 |/pl 187 27 5 33 |/pl 188 29 5 33 |/pl 189 31 5 33 |/pl 190 33 5 33 |/pl 191 35 5 33 |/pl 192 37 5 33 |/pl 193 39 5 33 |/pl 194 41 5 33 |/pl 195 43 5 33 |/pl 196 45 5 33 |/pl 197 47 5 33 |/pl 198 49 5 33 |/pl 199 51 5 33 |/pl 200 53 5 33 |/pl 201 15 5 35 |/pl 202 17 5 35 |/pl 203 19 5 35 |/pl 204 21 5 35 |/pl 205 23 5 35 |/pl 206 25 5 35 |/pl 207 27 5 35 |/pl 208 29 5 35 |/pl 209 31 5 35 |/pl 210 33 5 35 |/pl 211 35 5 35 |/pl 212 37 5 35 |/pl 213 39 5 35 |/pl 214 41 5 35 |/pl 215 43 5 35 |/pl 216 45 5 35 |/pl 217 47 5 35 |/pl 218 49 5 35 |/pl 219 51 5 35 |/pl 220 53 5 35 |/pl 221 15 5 37 |/pl 222 17 5 37 |/pl 223 19 5 37 |/pl 224 21 5 37 |/pl 225 23 5 37 |/pl 226 25 5 37 |/pl 227 27 5 37 |/pl 228 29 5 37 |/pl 229 31 5 37 |/pl 230 33 5 37 |/pl 231 35 5 37 |/pl 232 37 5 37 |/pl 233 39 5 37 |/pl 234 41 5 37 |/pl 235 43 5 37 |/pl 236 45 5 37 |/pl 237 47 5 37 |/pl 238 49 5 37 |/pl 239 51 5 37 |/pl 240 53 5 37 |/pl 241 15 5 39 |/pl 242 17 5 39 |/pl 243 19 5 39 |/pl 244 21 5 39 |/pl 245 23 5 39 |/pl 246 25 5 39 |/pl 247 27 5 39 |/pl 248 29 5 39 |/pl 249 31 5 39 |/pl 250 33 5 39 |/pl 251 35 5 39 |/pl 252 37 5 39 |/pl 253 39 5 39 |/pl 254 41 5 39 |/pl 255 43 5 39 |/pl 256 45 5 39 |/pl 257 47 5 39 |/pl 55 49 3 39 |/pl 258 49 5 39 |/pl 55 51 3 39 |/pl 259 51 5 39 |/pl 260 53 5 39 |/pl 261 15 5 41 |/pl 55 17 3 41 |/pl 262 17 5 41 |/pl 263 19 5 41 |/z 20 |/m 20 4 40 |/m 22 5 42 |/pl 0 21 4 41 |/pl 55 21 3 41 |/pl 264 21 5 41 |/z 20 |/m 22 4 40 |/m 24 5 42 |/pl 0 23 4 41 |/pl 55 23 3 41 |/pl 265 23 5 41 |/z 20 |/m 24 4 40 |/m 26 5 42 |/pl 0 25 4 41 |/pl 55 25 3 41 |/pl 266 25 5 41 |/z 20 |/m 26 4 40 |/m 28 5 42 |/pl 0 27 4 41 |/pl 55 27 3 41 |/pl 267 27 5 41 |/pl 55 29 3 41 |/pl 268 29 5 41 |/pl 55 31 3 41 |/pl 269 31 5 41 |/pl 270 33 5 41 |/pl 271 35 5 41 |/pl 272 37 5 41 |/pl 273 39 5 41 |/pl 274 41 5 41 |/pl 55 43 3 41 |/pl 275 43 5 41 |/pl 276 45 5 41 |/pl 277 47 5 41 |/pl 278 49 5 41 |/pl 279 51 5 41 |/pl 280 53 5 41 |/pl 281 15 5 43 |/pl 282 17 5 43 |/pl 283 19 5 43 |/pl 284 21 5 43 |/pl 285 23 5 43 |/pl 286 25 5 43 |/pl 287 27 5 43 |/pl 288 29 5 43 |/pl 289 31 5 43 |/pl 290 33 5 43 |/pl 291 35 5 43 |/pl 292 37 5 43 |/pl 55 39 3 43 |/pl 293 39 5 43 |/pl 55 41 3 43 |/pl 294 41 5 43 |/pl 55 43 3 43 |/pl 295 43 5 43 |/pl 55 45 3 43 |/pl 296 45 5 43 |/pl 297 47 5 43 |/pl 298 49 5 43 |/pl 299 51 5 43 |/pl 55 53 3 43 |/pl 300 53 5 43 |/pl 301 15 5 45 |/pl 55 17 3 45 |/pl 302 17 5 45 |/pl 303 19 5 45 |/pl 304 21 5 45 |/pl 305 23 5 45 |/pl 55 25 3 45 |/pl 306 25 5 45 |/pl 307 27 5 45 |/pl 308 29 5 45 |/pl 309 31 5 45 |/pl 310 33 5 45 |/pl 311 35 5 45 |/pl 312 37 5 45 |/pl 313 39 5 45 |/pl 314 41 5 45 |/pl 315 43 5 45 |/pl 316 45 5 45 |/pl 317 47 5 45 |/pl 318 49 5 45 |/pl 319 51 5 45 |/pl 320 53 5 45 |/pl 321 15 5 47 |/pl 322 17 5 47 |/pl 323 19 5 47 |/pl 324 21 5 47 |/pl 325 23 5 47 |/pl 326 25 5 47 |/pl 327 27 5 47 |/pl 328 29 5 47 |/pl 329 31 5 47 |/pl 330 33 5 47 |/pl 331 35 5 47 |/pl 332 37 5 47 |/pl 333 39 5 47 |/pl 334 41 5 47 |/pl 335 43 5 47 |/pl 336 45 5 47 |/pl 337 47 5 47 |/pl 338 49 5 47 |/pl 339 51 5 47 |/pl 340 53 5 47 |/pl 341 15 5 49 |/pl 342 17 5 49 |/pl 343 19 5 49 |/pl 344 21 5 49 |/pl 345 23 5 49 |/pl 346 25 5 49 |/pl 347 27 5 49 |/pl 348 29 5 49 |/pl 349 31 5 49 |/pl 350 33 5 49 |/pl 351 35 5 49 |/pl 352 37 5 49 |/pl 353 39 5 49 |/pl 354 41 5 49 |/pl 355 43 5 49 |/pl 356 45 5 49 |/pl 357 47 5 49 |/pl 358 49 5 49 |/pl 359 51 5 49 |/pl 360 53 5 49 |/pl 361 15 5 51 |/pl 362 17 5 51 |/pl 363 19 5 51 |/pl 364 21 5 51 |/pl 365 23 5 51 |/pl 366 25 5 51 |/pl 367 27 5 51 |/pl 368 29 5 51 |/pl 369 31 5 51 |/pl 370 33 5 51 |/pl 371 35 5 51 |/pl 372 37 5 51 |/pl 373 39 5 51 |/pl 374 41 5 51 |/pl 375 43 5 51 |/pl 376 45 5 51 |/pl 377 47 5 51 |/pl 378 49 5 51 |/pl 379 51 5 51 |/pl 380 53 5 51 |/pl 381 15 5 53 |/pl 382 17 5 53 |/pl 383 19 5 53 |/pl 384 21 5 53 |/pl 385 23 5 53 |/pl 386 25 5 53 |/pl 387 27 5 53 |/pl 388 29 5 53 |/pl 389 31 5 53 |/pl 390 33 5 53 |/pl 391 35 5 53 |/pl 392 37 5 53 |/pl 393 39 5 53 |/pl 394 41 5 53 |/pl 395 43 5 53 |/pl 396 45 5 53 |/pl 397 47 5 53 |/pl 398 49 5 53 |/pl 399 51 5 53 |/pl 400 53 5 53 |/pl 401 15 5 55 |/pl 402 17 5 55 |/pl 403 19 5 55 |/pl 404 21 5 55 |/pl 405 23 5 55 |/pl 406 25 5 55 |/pl 407 27 5 55 |/pl 408 29 5 55 |/pl 409 31 5 55 |/pl 410 33 5 55 |/pl 411 35 5 55 |/pl 412 37 5 55 |/pl 413 39 5 55 |/pl 414 41 5 55 |/pl 415 43 5 55 |/pl 416 45 5 55 |/pl 417 47 5 55 |/pl 418 49 5 55 |/pl 419 51 5 55 |/pl 420 53 5 55 |/pl 421 15 5 57 |/pl 422 17 5 57 |/pl 423 19 5 57 |/pl 424 21 5 57 |/pl 425 23 5 57 |/pl 426 25 5 57 |/pl 427 27 5 57 |/pl 428 29 5 57 |/pl 429 31 5 57 |/pl 430 33 5 57 |/pl 431 35 5 57 |/pl 432 37 5 57 |/pl 433 39 5 57 |/pl 434 41 5 57 |/pl 435 43 5 57 |/pl 436 45 5 57 |/pl 437 47 5 57 |/pl 438 49 5 57 |/pl 439 51 5 57 |/pl 440 53 5 57 |/pl 441 15 5 59 |/pl 442 17 5 59 |/pl 443 19 5 59 |/pl 444 21 5 59 |/pl 445 23 5 59 |/pl 446 25 5 59 |/pl 447 27 5 59 |/pl 448 29 5 59 |/pl 449 31 5 59 |/pl 450 33 5 59 |/pl 451 35 5 59 |/pl 452 37 5 59 |/pl 453 39 5 59 |/pl 454 41 5 59 |/pl 455 43 5 59 |/pl 456 45 5 59 |/pl 457 47 5 59 |/pl 458 49 5 59 |/pl 459 51 5 59 |/pl 460 53 5 59 |/pl 461 15 5 61 |/pl 462 17 5 61 |/pl 463 19 5 61 |/pl 464 21 5 61 |/pl 465 23 5 61 |/pl 466 25 5 61 |/pl 467 27 5 61 |/pl 468 29 5 61 |/pl 469 31 5 61 |/pl 470 33 5 61 |/pl 471 35 5 61 |/pl 472 37 5 61 |/pl 473 39 5 61 |/pl 474 41 5 61 |/pl 475 43 5 61 |/pl 476 45 5 61 |/pl 477 47 5 61 |/pl 478 49 5 61 |/pl 479 51 5 61 |/pl 480 53 5 61 |/pl 481 15 5 63 |/pl 482 17 5 63 |/pl 483 19 5 63 |/pl 484 21 5 63 |/pl 485 23 5 63 |/pl 486 25 5 63 |/pl 487 27 5 63 |/pl 488 29 5 63 |/pl 489 31 5 63 |/pl 490 33 5 63 |/pl 491 35 5 63 |/pl 492 37 5 63 |/pl 493 39 5 63 |/pl 494 41 5 63 |/pl 495 43 5 63 |/pl 496 45 5 63 |/pl 497 47 5 63 |/pl 498 49 5 63 |/pl 499 51 5 63 |/pl 500 53 5 63 |/pl 501 15 5 65 |/pl 502 17 5 65 |/pl 503 19 5 65 |/pl 504 21 5 65 |/pl 505 23 5 65 |/pl 506 25 5 65 |/pl 507 27 5 65 |/pl 508 29 5 65 |/pl 509 31 5 65 |/pl 510 33 5 65 |/pl 511 35 5 65 |/pl 512 37 5 65 |/pl 513 39 5 65 |/pl 55 41 3 65 |/pl 514 41 5 65 |/pl 55 43 3 65 |/pl 515 43 5 65 |/pl 516 45 5 65 |/pl 517 47 5 65 |/pl 55 49 3 65 |/pl 518 49 5 65 |/pl 519 51 5 65 |/z 20 |/m 52 4 64 |/m 54 5 66 |/pl 0 53 4 65 |/pl 55 53 3 65 |/pl 520 53 5 65 |/z 20 |/m 14 4 66 |/m 16 5 68 |/pl 0 15 4 67 |/pl 55 15 3 67 |/pl 521 15 5 67 |/z 20 |/m 16 4 66 |/m 18 5 68 |/pl 0 17 4 67 |/pl 55 17 3 67 |/pl 522 17 5 67 |/z 20 |/m 18 4 66 |/m 20 5 68 |/pl 0 19 4 67 |/pl 55 19 3 67 |/pl 523 19 5 67 |/pl 55 21 3 67 |/pl 524 21 5 67 |/pl 55 23 3 67 |/pl 525 23 5 67 |/pl 526 25 5 67 |/pl 527 27 5 67 |/pl 528 29 5 67 |/pl 529 31 5 67 |/pl 530 33 5 67 |/pl 55 35 3 67 |/pl 531 35 5 67 |/pl 532 37 5 67 |/pl 533 39 5 67 |/pl 534 41 5 67 |/pl 535 43 5 67 |/pl 536 45 5 67 |/pl 537 47 5 67 |/pl 538 49 5 67 |/pl 539 51 5 67 |/pl 540 53 5 67 |/pl 541 15 5 69 |/pl 542 17 5 69 |/pl 543 19 5 69 |/pl 544 21 5 69 |/pl 545 23 5 69 |/pl 546 25 5 69 |/pl 547 27 5 69 |/pl 548 29 5 69 |/pl 55 31 3 69 |/pl 549 31 5 69 |/pl 55 33 3 69 |/pl 550 33 5 69 |/pl 55 35 3 69 |/pl 551 35 5 69 |/pl 55 37 3 69 |/pl 552 37 5 69 |/pl 553 39 5 69 |/pl 554 41 5 69 |/pl 555 43 5 69 |/pl 55 45 3 69 |/pl 556 45 5 69 |/pl 557 47 5 69 |/pl 55 49 3 69 |/pl 558 49 5 69 |/pl 559 51 5 69 |/pl 560 53 5 69 |/pl 561 15 5 71 |/pl 55 17 3 71 |/pl 562 17 5 71 |/pl 563 19 5 71 |/pl 564 21 5 71 |/pl 565 23 5 71 |/pl 566 25 5 71 |/pl 567 27 5 71 |/pl 568 29 5 71 |/pl 569 31 5 71 |/pl 570 33 5 71 |/pl 571 35 5 71 |/pl 572 37 5 71 |/pl 573 39 5 71 |/pl 574 41 5 71 |/pl 575 43 5 71 |/pl 576 45 5 71 |/pl 577 47 5 71 |/pl 578 49 5 71 |/pl 579 51 5 71 |/pl 580 53 5 71 |/pl 581 15 5 73 |/pl 582 17 5 73 |/pl 583 19 5 73 |/pl 584 21 5 73 |/pl 585 23 5 73 |/pl 586 25 5 73 |/pl 587 27 5 73 |/pl 588 29 5 73 |/pl 589 31 5 73 |/pl 590 33 5 73 |/pl 591 35 5 73 |/pl 592 37 5 73 |/pl 593 39 5 73 |/pl 594 41 5 73 |/pl 595 43 5 73 |/pl 596 45 5 73 |/pl 597 47 5 73 |/pl 598 49 5 73 |/pl 599 51 5 73 |/pl 600 53 5 73 |/pl 601 15 5 75 |/pl 602 17 5 75 |/pl 603 19 5 75 |/pl 604 21 5 75 |/pl 605 23 5 75 |/pl 606 25 5 75 |/pl 607 27 5 75 |/pl 608 29 5 75 |/pl 609 31 5 75 |/pl 610 33 5 75 |/pl 611 35 5 75 |/pl 612 37 5 75 |/pl 613 39 5 75 |/pl 614 41 5 75 |/pl 615 43 5 75 |/pl 616 45 5 75 |/pl 617 47 5 75 |/pl 618 49 5 75 |/pl 619 51 5 75 |/pl 620 53 5 75 |/pl 621 15 5 77 |/pl 622 17 5 77 |/pl 623 19 5 77 |/pl 624 21 5 77 |/pl 625 23 5 77 |/pl 626 25 5 77 |/pl 627 27 5 77 |/pl 628 29 5 77 |/pl 629 31 5 77 |/pl 630 33 5 77 |/pl 631 35 5 77 |/pl 632 37 5 77 |/pl 633 39 5 77 |/pl 634 41 5 77 |/pl 635 43 5 77 |/pl 636 45 5 77 |/pl 637 47 5 77 |/pl 638 49 5 77 |/pl 639 51 5 77 |/pl 640 53 5 77 |/pl 641 15 5 79 |/pl 642 17 5 79 |/pl 643 19 5 79 |/pl 644 21 5 79 |/pl 645 23 5 79 |/pl 646 25 5 79 |/pl 647 27 5 79 |/pl 648 29 5 79 |/pl 649 31 5 79 |/pl 650 33 5 79 |/pl 651 35 5 79 |/pl 652 37 5 79 |/pl 653 39 5 79 |/pl 654 41 5 79 |/pl 655 43 5 79 |/pl 656 45 5 79 |/pl 657 47 5 79 |/pl 658 49 5 79 |/pl 659 51 5 79 |/pl 660 53 5 79 |/pl 661 15 5 81 |/pl 662 17 5 81 |/pl 663 19 5 81 |/pl 664 21 5 81 |/pl 665 23 5 81 |/pl 666 25 5 81 |/pl 667 27 5 81 |/pl 668 29 5 81 |/pl 669 31 5 81 |/pl 670 33 5 81 |/pl 671 35 5 81 |/pl 672 37 5 81 |/pl 673 39 5 81 |/pl 674 41 5 81 |/pl 675 43 5 81 |/pl 676 45 5 81 |/pl 677 47 5 81 |/pl 678 49 5 81 |/pl 679 51 5 81 |/pl 680 53 5 81 |/pl 681 15 5 83 |/pl 682 17 5 83 |/pl 683 19 5 83 |/pl 684 21 5 83 |/pl 685 23 5 83 |/pl 686 25 5 83 |/pl 687 27 5 83 |/pl 688 29 5 83 |/pl 689 31 5 83 |/pl 690 33 5 83 |/pl 691 35 5 83 |/pl 692 37 5 83 |/pl 693 39 5 83 |/pl 694 41 5 83 |/pl 695 43 5 83 |/pl 696 45 5 83 |/pl 697 47 5 83 |/pl 698 49 5 83 |/pl 699 51 5 83 |/pl 700 53 5 83 |/pl 701 15 5 85 |/pl 702 17 5 85 |/pl 703 19 5 85 |/pl 704 21 5 85 |/pl 705 23 5 85 |/pl 706 25 5 85 |/pl 707 27 5 85 |/pl 708 29 5 85 |/pl 709 31 5 85 |/pl 710 33 5 85 |/pl 711 35 5 85 |/pl 712 37 5 85 |/pl 713 39 5 85 |/pl 714 41 5 85 |/pl 715 43 5 85 |/pl 716 45 5 85 |/pl 717 47 5 85 |/pl 718 49 5 85 |/pl 719 51 5 85 |/pl 720 53 5 85 |/pl 721 15 5 87 |/pl 722 17 5 87 |/pl 723 19 5 87 |/pl 724 21 5 87 |/pl 725 23 5 87 |/pl 726 25 5 87 |/pl 727 27 5 87 |/pl 728 29 5 87 |/pl 729 31 5 87 |/pl 730 33 5 87 |/pl 731 35 5 87 |/pl 732 37 5 87 |/pl 733 39 5 87 |/pl 734 41 5 87 |/pl 735 43 5 87 |/pl 736 45 5 87 |/pl 737 47 5 87 |/pl 738 49 5 87 |/pl 739 51 5 87 |/pl 740 53 5 87 |/pl 741 15 5 89 |/pl 742 17 5 89 |/pl 743 19 5 89 |/pl 744 21 5 89 |/pl 745 23 5 89 |/pl 746 25 5 89 |/pl 747 27 5 89 |/pl 748 29 5 89 |/pl 749 31 5 89 |/pl 750 33 5 89 |/pl 751 35 5 89 |/pl 752 37 5 89 |/pl 753 39 5 89 |/pl 754 41 5 89 |/pl 755 43 5 89 |/pl 756 45 5 89 |/pl 757 47 5 89 |/pl 758 49 5 89 |/pl 759 51 5 89 |/pl 760 53 5 89 |/pl 761 15 5 91 |/pl 762 17 5 91 |/pl 763 19 5 91 |/pl 764 21 5 91 |/pl 765 23 5 91 |/pl 766 25 5 91 |/pl 767 27 5 91 |/z Op_Air |/m 33 5 11 |/m 35 8 12 |/z Op_Air |/m 33 6 13 |/m 35 8 z |/pl 20 34 5 12 |/pl GlassTile-U 34 5 12 |/tp 34 6 12 180 0 |/os setspawn |/ignore drawoutput |/spawn |/reload |/hug BobTheBuilder+
/sendcmd BobTheBuilder+ mark 0 0 0
/sendcmd BobTheBuilder+ mark 0 0 0

I've actually got a named pipe attached to the console, but pasting was working fine too, for smaller files.

Why: it lets me script things using tools I'm used to.

Oh, and my record is about half a gigabyte of message block, though that wasn't intentional, I just didn't notice my script had broken. Luckily I was passing most of the data to a custom C# command class so it didn't crash the server. Just made the machine a little sluggish for a minute.

@Goodlyay
Copy link
Collaborator

Goodlyay commented Apr 22, 2021

So if I'm understanding correctly, you want a way to turn off chat when using a scripted command sequence, then turn it back on? this unusual use case could be achieved with a very simple custom command.
(This example assumes ignoring blockdefinition edits is implemented)
https://pastebin.com/MwGUegQz

Then the first command you run would be /ignoreeverything true, last command /ignoreeverything false
or whatever you decide to name the command

Are you in the ClassiCube discord btw? It would probably be easier to figure out how to solve your issues in a live chat

@rdebath
Copy link
Contributor Author

rdebath commented Apr 22, 2021

No, p.Ignores.All doesn't do anything useful here. It only ignores chat from other players; there probably aren't any.
It doesn't ignore the Stone block was placed at (0, 0, 0). message or similar.

Obviously if commands notice p.Ignores.DrawOutput I can easily do the same for that flag, or all of them for that matter.
Also same for pausing physics and blockdb.

Okay I missed your "assuming ..." bit.

I'll move that bit into the custom extension as you don't like it. I'v made the changes but will do a little testing of them tomorrow, before I push them, as I seem to be a bit tired. 🙁

@Goodlyay
Copy link
Collaborator

sorry for the confusion. i edited my example command a bit late, i mistakenly thought p.Ignores.All worked on literally all chat. the current version of it would work for drawoutput though.
i’m also not against implementing a new flag to ignore block definition changes into vanilla mcgalaxy, to be clear

@rdebath
Copy link
Contributor Author

rdebath commented Apr 23, 2021

No problem,
I've removed the /ignore none and added /ignore BlockdefChanges as named in your paste.
Also the CPE check for mark requests (good thing I tested, I'd messed up the De Morgan's laws.)

I think I'll stop trying to control the messages on the fly and just make sure to always use Zombie builder Bob rather than my user. BTW: Is there a suggested method of creating a player (that I can /sendcmd to) without using any client connection?

robert and others added 3 commits July 1, 2021 12:25
Already shown by prompt.
    "Place or break two blocks to determine the edges."

No news is good news.
    "Created a new " + scope + " custom block"...
    "Duplicated the {0} custom block "...
    "Copied the {0} custom block "...

Any error or warning will be shown, but if the message is expected it
is suppressed, for example, a missing block for block remove command is
not a problem.
Rename to BlockdefChanges
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants