Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WSS change #664

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

WSS change #664

wants to merge 3 commits into from

Conversation

gwhizoftv
Copy link

Modify Sockets.cs to support wss:// connections

@gwhizoftv
Copy link
Author

Sorry about the whitespace changes

@UnknownShadow200
Copy link
Collaborator

There seem to be three changes here

  1. Adding a lot of logging
  2. Changing ServicePointManager to TLS 1.2 only (seems unnecessary because something similar is already done in ForceEnableTLS method in Server.cs)
  3. Changing SSLStream for secure websockets to use TLS 1.2 only

Seems like would be simpler to just change ssl.AuthenticateAsServer(cert); to ssl.AuthenticateAsServer(cert, false, HttpUtil.TLS_ALL, false); ?

@gwhizoftv
Copy link
Author

  1. Yes the logging helps the admin get the correct cert deployed. We should document the process of getting the correct type of cert.
  2. I saw the TLS code in the other module but it didn't seem to be working.Also the Tls12 enums weren't available in Sockets.js.
  3. Yes. We don't want to allow TLS 1.0 but 1.1 and later are OK. There are a bunch of options defined in the M$FT C# pages for AuthenticateAsServer but our compile system didn't recognize some of them. The one I put there works. We don't need the client to present or auth to us, unless we are going to a completely different level of authentication.
  4. Changing the x509 routine to the one that doesn't need a password. For a public cert we don't want a password.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants